copy-dialog-lunar-lander: Add version 1.2 #16858
Conversation
WalkthroughA new Scoop-style manifest Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with copydialoglunarlander
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bucket/copydialoglunarlander.json (1)
21-23: Hash field is missing from autoupdate; verify if upstream provides hashes.The autoupdate block lacks a hash field for integrity verification. While optional, adding hash extraction would improve package integrity during automatic updates if the upstream project provides verifiable hashes. If Copy Dialog Lunar Lander doesn't publish hashes, the current configuration is acceptable.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/copydialoglunarlander.json(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.
📚 Learning: 2025-10-19T13:58:23.389Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.
Applied to files:
bucket/copydialoglunarlander.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (3)
bucket/copydialoglunarlander.json (3)
8-8: LGTM!Adding the installation directory to PATH is appropriate for making the executable accessible.
6-7: Verify the hash matches the v1.2 release asset.The download URL is correct for the v1.2 release, but confirm the SHA-256 hash by downloading the file or checking the release page for published checksums. The hash format is valid, but the actual correctness requires verification against the actual MSI file.
9-19: Verify the icon file exists in the MSI package.The shortcut configuration references
LunarLander.ico, which must be present in the MSI for Scoop's shortcut creation to succeed. If the upstream MSI doesn't include this icon file, users will encounter errors when installing via this Scoop bucket.
Fix typo in description field
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with copydialoglunarlander
|
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with copydialoglunarlander
|
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with copydialoglunarlander
|
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with copydialoglunarlander
|
Fix JSON formatting by adding missing newline
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with copydialoglunarlander
|
Why still don't pass Lint :( |
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with copydialoglunarlander
|
The answer is already explained in this comment. Simply click the links to see what these checks mean. |
|
Carefully review the provided suggestions. I'd suggest getting a better understanding of how it works first, rather than opening a large number of PRs right away. |
|
/verify |
|
All changes look good. Wait for review from human collaborators. copydialoglunarlander
|
|
I tried to rewrite the file and found that I missed |
There was a problem hiding this comment.
-
I tried to rewrite the file and found that I missed
extract_dir."extract_dir": ".",I don't see a clear need for
extract_dir. Please remove theextract_dirproperty.
https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests#optional-propertiesextract_dir: If url points to a compressed file (.zip, .7z, .tar, .gz, .lzma, and .lzh are supported), Scoop will extract just the directory specified from it.
-
Is the manifest name reasonable?
copydialoglunarlanderis a long concatenated string and is not very readable. I suggest renaming it tocopy-dialog-lunar-lander.json. -
Simplify
checkver. You can simply use"checkver": "github". -
Please ensure that the commands I mentioned have been executed. After running the commands, the hash should be in lowercase.
#16844 (comment)
2. Properly format, update and test all the manifests in your PRs.
.\bin\checkver.ps1 -App <package> -f .\bin\formatjson.ps1 -App <package> scoop install "C:\Users\username\Desktop\pr\<package>.json" -a <arch>
The same applies to all the PRs you have raised.
|
Thank you for your advice and help! |
…r; update checkver
|
/verify |
|
All changes look good. Wait for review from human collaborators. copydialoglunarlander
|
|
|
Right, I was careless. |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bucket/copy-dialog-lunar-lander.json (1)
6-15:extract_diris recommended for MSI manifests with shortcuts, though not strictly required.While many MSI manifests include
extract_dirto explicitly specify the extracted directory structure (e.g.,"extract_dir": "PFiles\\AppName"), active manifests in this repository likeisocreator.jsonandclustalx.jsonfunction without it. Addingextract_dirwould improve clarity and reliability by explicitly pointing to the extracted application directory after lessmsi extraction. Common patterns:"PFiles\\AppName"or"PFiles64\\AppName". Refer to similar MSI manifests in the bucket for the appropriate directory structure.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/copy-dialog-lunar-lander.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-10-19T13:58:23.389Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.
Applied to files:
bucket/copy-dialog-lunar-lander.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (3)
bucket/copy-dialog-lunar-lander.json (3)
1-5: Metadata looks good.The version, description, homepage, and license fields are all properly formatted and accurate.
16-16: LGTM!The
checkver: "github"strategy is appropriate for this GitHub-hosted project.
17-19: No hash verification needed—the autoupdate URL is correctly configured.The release does not provide published checksums, so hash verification cannot be added. The autoupdate block is properly configured as-is.
z-Fng
changed the title
|
/verify |
|
All changes look good. Wait for review from human collaborators. copy-dialog-lunar-lander
|
z-Fng
left a comment
z-Fng
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
The manifest will update automatically as the package updates, as long as the upstream releases new packages that follow the same pattern defined in the manifest. If there are any other changes, feel free to submit a PR.
2 participants
Closes #16857
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.