-
Notifications
You must be signed in to change notification settings - Fork 1.6k
nomeiryoui@3.4.0: Remove architecture field, add shortcuts #16875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughConsolidated architecture-specific manifest entries in Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (5)📓 Common learnings📚 Learning: 2025-11-29T22:02:34.868ZApplied to files:
📚 Learning: 2025-10-16T15:59:21.258ZApplied to files:
📚 Learning: 2025-09-05T09:41:52.653ZApplied to files:
📚 Learning: 2025-09-05T09:41:52.653ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. nomeiryoui
|
|
Please modify the The test results are as follows:┏[ ~]
└─> scoop update noMeiryoUI -f
noMeiryoUI: 3.4.0 -> 3.4.0
Updating one outdated app:
Updating 'noMeiryoUI' (3.4.0 -> 3.4.0)
Downloading new version
Loading noMeiryoUI3.4.0.zip from cache.
Checking hash of noMeiryoUI3.4.0.zip ... ok.
Uninstalling 'noMeiryoUI' (3.4.0)
Removing shim 'noMeiryoUI.shim'.
Removing shim 'noMeiryoUI.exe'.
Unlinking D:\Software\Scoop\Local\apps\noMeiryoUI\current
Installing 'noMeiryoUI' (3.4.0) [64bit] from 'Extras' bucket
Loading noMeiryoUI3.4.0.zip from cache.
Extracting noMeiryoUI3.4.0.zip ... done.
Running pre_install script...
Directory: D:\Software\Scoop\Local\apps\noMeiryoUI\3.4.0
Mode LastWriteTime Length Name
---- ------------- ------ ----
-a--- 2025/12/25 1:03 0 noMeiryoUI.ini
done.
Linking D:\Software\Scoop\Local\apps\noMeiryoUI\current => D:\Software\Scoop\Local\apps\noMeiryoUI\3.4.0
Creating shim for 'noMeiryoUI'.
Making D:\Software\Scoop\Local\shims\nomeiryoui.exe a GUI binary.
Persisting noMeiryoUI.ini
'noMeiryoUI' (3.4.0) was installed successfully!
┏[ ~]
└─> Get-ChildItem -Path $(scoop prefix noMeiryoUI) -Filter 'noMeiryoUI.ini*'
Directory: D:\Software\Scoop\Local\apps\noMeiryoUI\current
Mode LastWriteTime Length Name
---- ------------- ------ ----
la--- 2025/12/21 16:01 48 noMeiryoUI.ini
-a--- 2025/12/25 1:03 0 noMeiryoUI.ini.original
An example of the revised version is provided below:┏[ D:\Temporary\Software\Microsoft\Windows Sandbox\Repositories\Scoop\Buckets\Unofficial][ master ≡]
└─> jq '{pre_install, bin, shortcuts}' '.\bucket\n\nomeiryoui.json'
{
"pre_install": [
"if (-not (Test-Path \"$persist_dir\\noMeiryoUI.ini\")) {",
" New-Item -Path \"$dir\\noMeiryoUI.ini\" -ItemType File -Force | Out-Null",
"}"
],
"bin": "noMeiryoUI.exe",
"shortcuts": [
[
"noMeiryoUI.exe",
"No!! Meiryo UI"
]
]
} |
Please create a separate PR for this change next time, as others may not fully understand the change you're trying to make. #16452 is a good example of why. |
|
/verify |
|
All changes look good. Wait for review from human collaborators. nomeiryoui
|
z-Fng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you both for your contributions!
Ok, thank you for your reminder. |
The Detect-It-Easy show it be 32-bit. So can write its
architecturetourl.<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.