Skip to content

Conversation

@boskoop
Copy link
Contributor

@boskoop boskoop commented Dec 26, 2025

Closes #16886

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

I tested installing x64 and x86 as well as the autoupdate with checkver.ps1:

PS> C:\Scoop\apps\scoop\current\bin\checkver.ps1 -Dir . -App foxit-reader
foxit-reader: 2025.3.0

Summary by CodeRabbit

  • Chores
    • Foxit Reader and Foxit PDF Reader updated to version 2025.3.0
    • Installer packages and security verification hashes refreshed for both 32‑bit and 64‑bit builds
    • CDN host changed to cdn01.foxitsoftware.com and autoupdate paths updated to reflect the new version and delivery endpoints

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 26, 2025

Walkthrough

Updated two Foxit manifests: bumped version to 2025.3.0, switched CDN host from cdn78.foxitsoftware.com to cdn01.foxitsoftware.com, and updated 64‑bit/32‑bit installer URLs, autoupdate endpoints, and corresponding SHA‑1 hashes.

Changes

Cohort / File(s) Summary
Foxit manifests
bucket/foxit-reader.json, bucket/foxit-pdf-reader.json
Version bump 2025.2.1 → 2025.3.0; CDN host changed to cdn01.foxitsoftware.com; updated 64‑bit and 32‑bit installer URLs and autoupdate URL templates; refreshed SHA‑1 checksums for installers.

Sequence Diagram(s)

(omitted — changes are version/URL/hash updates without new multi-component control flow)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 A hop, a click, the links renew,
From cdn78 to cdn01 they flew.
Version bumped, checksums in line,
PDFs ready, sleek and fine. 🥕📄

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: updating foxit(-pdf)-reader to version 2025.3.0 and fixing autoupdate functionality.
Description check ✅ Passed The description includes the required elements: a reference to linked issue #16886, confirmation of testing both x64 and x86 installations and autoupdate verification, and both checklist items completed.
Linked Issues check ✅ Passed The PR directly addresses all requirements from issue #16886: updates both foxit-reader and foxit-pdf-reader to version 2025.3.0, changes CDN host from cdn78 to cdn01, and fixes autoupdate URLs [#16886].
Out of Scope Changes check ✅ Passed All changes are scoped to updating the two Foxit manifest files with version 2025.3.0, CDN host updates, and autoupdate URL fixes; no unrelated modifications present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

foxit-pdf-reader

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

foxit-reader

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng z-Fng changed the title foxit-reader@2025.3.0: Update to new version and fix download url foxit(-pdf)-reader: Update to version 2025.3.0, fix autoupdate Dec 26, 2025
Removed CDN note from foxit-pdf-reader.json.
Removed CDN note for foxit-reader synchronization.
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7cdbdb5 and 255fb6b.

📒 Files selected for processing (2)
  • bucket/foxit-pdf-reader.json
  • bucket/foxit-reader.json
🧰 Additional context used
🧠 Learnings (6)
📓 Common learnings
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16341
File: bucket/foxit-pdf-reader.json:47-50
Timestamp: 2025-10-15T11:54:31.320Z
Learning: In bucket/foxit-pdf-reader.json and bucket/foxit-reader.json, the checkver script uses MaximumRedirection 1 (not 0) for Invoke-WebRequest to properly handle Foxit's backend redirect behavior when parsing the Location header for version detection.
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.
📚 Learning: 2025-10-15T11:54:31.320Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16341
File: bucket/foxit-pdf-reader.json:47-50
Timestamp: 2025-10-15T11:54:31.320Z
Learning: In bucket/foxit-pdf-reader.json and bucket/foxit-reader.json, the checkver script uses MaximumRedirection 1 (not 0) for Invoke-WebRequest to properly handle Foxit's backend redirect behavior when parsing the Location header for version detection.

Applied to files:

  • bucket/foxit-reader.json
  • bucket/foxit-pdf-reader.json
📚 Learning: 2025-10-16T15:59:21.258Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16349
File: bucket/fvim.json:45-49
Timestamp: 2025-10-16T15:59:21.258Z
Learning: In Scoop manifests, the `autoupdate.url` and `autoupdate.architecture.<arch>.url` fields must be valid URIs according to the JSON schema (defined with `"format": "uri"`). Variables like `$matchUrlx64` that contain only path segments must be combined with a base URL (e.g., `https://github.com/.../releases/download/`) to form a complete valid URI.

Applied to files:

  • bucket/foxit-reader.json
  • bucket/foxit-pdf-reader.json
📚 Learning: 2025-09-05T09:41:52.653Z
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.

Applied to files:

  • bucket/foxit-reader.json
  • bucket/foxit-pdf-reader.json
📚 Learning: 2025-10-16T13:42:43.224Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16349
File: bucket/debugviewpp.json:14-21
Timestamp: 2025-10-16T13:42:43.224Z
Learning: In the DebugViewPP project (CobaltFusion/DebugViewPP), the executable name changed from "DebugView++.exe" (in v1.8.0.103 and earlier) to "Debugviewpp.exe" (in v1.9.0.28 and later). The manifest bucket/debugviewpp.json correctly uses "Debugviewpp.exe" for current versions.

Applied to files:

  • bucket/foxit-pdf-reader.json
📚 Learning: 2025-10-19T13:58:23.389Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.

Applied to files:

  • bucket/foxit-pdf-reader.json
🔇 Additional comments (2)
bucket/foxit-pdf-reader.json (1)

52-52: Autoupdate URLs correctly updated to cdn01.

The autoupdate URL templates now reference the new CDN host (cdn01) while properly using $version and $matchFname64/$matchFname32 variables from the checkver regex. This ensures autoupdate will construct correct URLs for future versions as long as Foxit continues using cdn01.

Also applies to: 55-55

bucket/foxit-reader.json (1)

2-2: Files properly synchronized.

All changes in foxit-reader.json match foxit-pdf-reader.json exactly (version, URLs, hashes, autoupdate templates). This maintains the required synchronization between both manifests as specified in line 2.

Also applies to: 3-3, 12-13, 16-17, 52-52, 55-55

Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@z-Fng z-Fng merged commit 5c88e09 into ScoopInstaller:master Dec 26, 2025
3 checks passed
@boskoop boskoop deleted the foxit-2025-3-0 branch December 26, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: foxit(-pdf)-reader@2025.2.1: download for 2025.2.1 no longer works; version 2025.3.0 is available

2 participants