-
Notifications
You must be signed in to change notification settings - Fork 1.6k
nomacs: Update to version 3.22.0, enable checkver #16924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdates nomacs package metadata in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Pre-merge checks✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. nomacs
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. nomacs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
bucket/nomacs.json (1)
27-29: LGTM! Checkver enables automated version checking.The
checkverblock correctly references the GitHub repository and enables automated version checking as indicated in the commit message.Optionally, you can use the shorter format for GitHub checkver:
🔎 Optional: Shorter checkver format
- "checkver": { - "github": "https://github.com/nomacs/nomacs" - }, + "checkver": "github",Both formats work, but the shorter format is more concise when the homepage already points to GitHub (though in this case the homepage is nomacs.org, so the current format is actually clearer).
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/nomacs.json
🔇 Additional comments (3)
bucket/nomacs.json (3)
17-19: LGTM! Uninstaller correctly preserves settings.The uninstaller script properly mirrors the pre_install logic by copying
settings.iniback topersist_dir, ensuring user settings are preserved across updates and reinstalls.
20-26: LGTM! Standard bin and shortcuts entries.The additions of
binandshortcutsentries are correctly formatted and follow Scoop conventions, making nomacs accessible via command line and Start Menu.
2-2: Verify the version, download URL, and hash against the actual GitHub release.The version bump to 3.22.0 requires manual verification that the GitHub release exists, the download URL is accessible, and the SHA-256 hash
53b0f952e321303e47d85ff53dc21c6ebaefb1bb8b849fae315b688f8702ff6ematches the downloaded file. Additionally, confirm whether 32-bit builds are available for this version.
z-Fng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Proposed update of nomacs to latest stable version 3.22.0.
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
Chores
New Features
✏️ Tip: You can customize this high-level summary in your review settings.