Skip to content

Conversation

@Zakor
Copy link
Contributor

@Zakor Zakor commented Jan 4, 2026

Proposed update of nomacs to latest stable version 3.22.0.

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Chores

    • Updated application version to 3.22.0 and package resources.
  • New Features

    • Added auto-update support using versioned releases.
    • Added application shortcut and executable entry for easier launch.
    • Added uninstall behavior to preserve and restore user settings on removal.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 4, 2026

Walkthrough

Updates nomacs package metadata in bucket/nomacs.json: bumps version to 3.22.0, updates download URL and SHA-256 for 64-bit, changes extract_dir, and adds checkver, uninstaller, bin/shortcuts, and autoupdate entries.

Changes

Cohort / File(s) Summary
Package metadata
bucket/nomacs.json
Version bump 3.16.17093.22.0; extract_dir updated to nomacs-3.22.0; 64-bit url and hash replaced with new release values.
Update automation
bucket/nomacs.json
Added checkver block pointing to GitHub releases; updated autoupdate to templated $version URLs and extract_dir = nomacs-$version.
Runtime / integration
bucket/nomacs.json
Added bin: nomacs.exe, shortcuts: nomacs, and an uninstaller script block that copies settings.ini back to persist_dir.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐇
A rabbit hops with version cheer,
Nomacs updated, threads draw near,
URLs, checksums neatly sewn,
Shortcuts placed and settings known,
Hoppity-hop — the bucket’s grown!

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'nomacs: Update to version 3.22.0' clearly and concisely summarizes the main change: updating the nomacs package to version 3.22.0, which aligns with the changeset modifications.
Description check ✅ Passed The PR description includes a brief summary of the proposed update and confirms completion of the required checklist items (conventional title and Contributing Guide read), though it lacks issue references or additional implementation details.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

All changes look good.

Wait for review from human collaborators.

nomacs

  • Lint
  • Description
  • License
  • Hashes

Check the full log for details.

@Zakor Zakor closed this Jan 4, 2026
@Zakor Zakor deleted the patch-2 branch January 4, 2026 14:35
@Zakor Zakor restored the patch-2 branch January 4, 2026 14:35
@Zakor Zakor reopened this Jan 4, 2026
@z-Fng
Copy link
Member

z-Fng commented Jan 4, 2026

/verify

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

All changes look good.

Wait for review from human collaborators.

nomacs

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng z-Fng changed the title nomacs: Update to version 3.22.0 nomacs: Update to version 3.22.0, enable checkver Jan 4, 2026
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
bucket/nomacs.json (1)

27-29: LGTM! Checkver enables automated version checking.

The checkver block correctly references the GitHub repository and enables automated version checking as indicated in the commit message.

Optionally, you can use the shorter format for GitHub checkver:

🔎 Optional: Shorter checkver format
-    "checkver": {
-        "github": "https://github.com/nomacs/nomacs"
-    },
+    "checkver": "github",

Both formats work, but the shorter format is more concise when the homepage already points to GitHub (though in this case the homepage is nomacs.org, so the current format is actually clearer).

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2c06e83 and ac25be6.

📒 Files selected for processing (1)
  • bucket/nomacs.json
🔇 Additional comments (3)
bucket/nomacs.json (3)

17-19: LGTM! Uninstaller correctly preserves settings.

The uninstaller script properly mirrors the pre_install logic by copying settings.ini back to persist_dir, ensuring user settings are preserved across updates and reinstalls.


20-26: LGTM! Standard bin and shortcuts entries.

The additions of bin and shortcuts entries are correctly formatted and follow Scoop conventions, making nomacs accessible via command line and Start Menu.


2-2: Verify the version, download URL, and hash against the actual GitHub release.

The version bump to 3.22.0 requires manual verification that the GitHub release exists, the download URL is accessible, and the SHA-256 hash 53b0f952e321303e47d85ff53dc21c6ebaefb1bb8b849fae315b688f8702ff6e matches the downloaded file. Additionally, confirm whether 32-bit builds are available for this version.

Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@z-Fng z-Fng merged commit 94ebf6d into ScoopInstaller:master Jan 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants