Skip to content

Conversation

@BlackWinnerYoshi
Copy link
Contributor

@BlackWinnerYoshi BlackWinnerYoshi commented Jan 5, 2026

86Box 5.0 introduced its own integrated manager, "meant to replace the old 86Box Manager and other simple front-ends": https://86box.net/2025/08/24/86box-v5-0.html

Closes #13899 (since the old Manager doesn't seem to be detecting 5.x+ in any way?)

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Chores
    • Updated project metadata, including license information and official homepage URL
    • Removed redundant suggestion entry

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 5, 2026

Walkthrough

Updated metadata in the 86box package manifest: homepage URL changed to official site, license updated to GPL-2.0-or-later, and removed the 86Box Manager suggestion entry from the manifest.

Changes

Cohort / File(s) Summary
86box manifest metadata
bucket/86box.json
Homepage updated to official site URL; license changed from GPL-2.0 to GPL-2.0-or-later; removed 86Box Manager from suggest list

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

review-needed

Poem

🐰 A rabbit hops through JSON lines,
Fixing licenses and old designs,
Homepage gleams with brighter light,
Suggestions pruned—the manifest is right!

Pre-merge checks

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: deprecating the 86box-manager manifest in response to 86Box 5.0's integrated manager replacement.
Description check ✅ Passed The description provides context about the deprecation, references 86Box 5.0's announcement, links to related issue #13899, and confirms compliance with conventional PR title and contributor guide requirements.
Linked Issues check ✅ Passed The PR addresses the core issue #13899 by deprecating the problematic manifest, which is an appropriate resolution given that 86Box 5.0 now includes its own integrated manager.
Out of Scope Changes check ✅ Passed All changes in bucket/86box.json are directly related to deprecating the 86box-manager manifest: homepage/license updates and removing 86Box Manager from suggestions align with the deprecation objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ebbdce5 and e530b9c.

📒 Files selected for processing (2)
  • bucket/86box.json
  • deprecated/86box-manager.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell
🔇 Additional comments (3)
bucket/86box.json (3)

12-14: No action needed—the change is correct as-is.

The 86box-manager.json manifest does not exist in this repository, so there is no manifest to mark as deprecated. The removal of the "86Box Manager" suggestion from the 86box.json manifest correctly reflects that 86Box 5.0+ includes an integrated manager.


4-4: Homepage URL is valid and accessible.

The official 86Box website at https://86box.net/ returns HTTP 200, confirming the URL is properly configured for the homepage field.


5-5: License designation is accurate.

The change from GPL-2.0 to GPL-2.0-or-later correctly reflects the 86Box repository's actual license, which is GPL version 2 or later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

All changes look good.

Wait for review from human collaborators.

86box

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: extras/86box-manager doesn't set default 86box.exe path when 86box was installed via scoop

1 participant