chore: Warn users to force update if innounp is on version 2025#71
chore: Warn users to force update if innounp is on version 2025#71deevus merged 1 commit intoScoopInstaller:mainfrom
Conversation
WalkthroughUpdated the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/Action/Issue/Extraction.psm1`:
- Around line 113-114: Update the NOTE text that currently references only
`innounp` to explicitly state whether `innounp-unicode` is also affected; if
both are affected, change the note string (the array element containing the '>
[!NOTE]' paragraph) to mention both `innounp` and `innounp-unicode` and include
both recovery commands (`scoop update innounp -f` and `scoop update
innounp-unicode -f`); if only `innounp` is affected, update that same note to
explain why `innounp-unicode` is still listed in the main instructions (for
example, it was included for completeness or is unaffected) so readers know
whether they need to run `scoop update innounp-unicode -f` as well.
🧹 Nitpick comments (1)
src/Action/Issue/Extraction.psm1 (1)
108-115: Consider scoping-fadvice to the affected version only.The
-fflag is now unconditionally recommended for all users in the code-block commands (lines 108, 111), even those not on the problematic 2025 version. While harmless, this is a heavier recommendation than necessary for unaffected users. Consider keeping the general advice without-fand reserving the force-update instruction for the NOTE block that specifically targets the 2025 version:Suggested restructuring
' ```', - ' scoop update innounp -f', + ' scoop update innounp', ' ```', ' ```', - ' scoop update innounp-unicode -f', + ' scoop update innounp-unicode', ' ```', '> [!NOTE]', - '> Innounp was previously incorrectly updated to version [2025](https://github.com/ScoopInstaller/Main/commit/64a7d914ab). Since this version number is higher than the actual latest version, it prevents automatic updates. If you are on this version, please run `scoop update innounp -f`.', + '> Innounp was previously incorrectly updated to version [2025](https://github.com/ScoopInstaller/Main/commit/64a7d914ab). Since this version number is higher than the actual latest version, it prevents automatic updates. If you are on this version, please run `scoop update innounp -f` or `scoop update innounp-unicode -f` instead.',This way the general advice stays lightweight, and only affected users are directed to force-update.
|
cc @ScoopInstaller/maintainers Could we merge this? (I don't have write access to this repository.) |
Description
This PR makes the following changes:
Motivation and Context
Innounp was previously incorrectly updated to version 2025 (ScoopInstaller/Main@64a7d914ab). Since this version number is higher than the actual latest version (currently 2.67.4), it blocks the automatic update process and has led to more frequent decompression errors.
Workaround for ScoopInstaller/Scoop#6572 and ScoopInstaller/Scoop#6595 (comment).
Related Issues
Testcase
Summary by CodeRabbit