-
Notifications
You must be signed in to change notification settings - Fork 105
Create graalvm25.json #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added installer of graalvm 25 - jdk25
WalkthroughAdds a new Scoop manifest Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Scoop
participant GitHub as "GitHub Releases"
participant Installer as "installer script"
participant Env as "Environment"
User->>Scoop: scoop install graalvm25
Scoop->>GitHub: download release zip (graalvm-community-jdk-25.0.0_...)
GitHub-->>Scoop: zip file
Scoop->>Scoop: extract to target directory
Scoop->>Installer: run installer script
Installer->>Scoop: move/reorganize extracted files
Installer->>Env: set JAVA_HOME and GRAALVM_HOME
Installer->>Env: add bin to PATH
User->>Scoop: scoop update graalvm25
Scoop->>GitHub: checkver (regex for 25.x)
alt new 25.x release found
Scoop->>Scoop: apply autoupdate URL template and new hash
else
Scoop-->>User: already up to date
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. graalvm25
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
just merge it |
This reverts commit ffd906d.
Added installer of graalvm 25 - jdk25
Added the installer for graalvm 25 with JDK 25 to the Java bucket
There is yet another PR which aims to add the installer for Temurin 25, I'm just adding the installer for GraalVM 25
Note: I edited the installer of GraalVM 21, where the regex under checkver/version permits only versions with at least a minor spec. In this one I loosen a bit the check to allow versions without minor on the github release page
Relates to #561
Closes #562
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.