-
Notifications
You must be signed in to change notification settings - Fork 105
Add graalvm25.json for GraalVM 25.0.1 #571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add graalvm25.json for GraalVM 25.0.1
WalkthroughA new Scoop manifest for GraalVM Community Edition 25.0.1 has been added, specifying Windows x64 installation configuration, including download details, SHA256 verification, environment variables (PATH, JAVA_HOME, GRAALVM_HOME), and autoupdate configuration linked to GitHub releases. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with graalvm25
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/bucket/graalvm25.json(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Pull Requests
bucket/bucket/graalvm25.json
[error] 1-1: Checkver failed. URL graalvm/graalvm-ce-builds/releases/latest is not valid.
🔇 Additional comments (1)
bucket/bucket/graalvm25.json (1)
20-23: Verification confirmed—checkver configuration is valid and endpoint is accessible.All verification checks passed:
- Repository
graalvm/graalvm-ce-buildsexists and is publicly accessible- Releases matching the regex pattern exist:
jdk-25.0.1andjdk-25.0.0- The regex
jdk-(25[\\d.]+)correctly captures available release tags- GitHub API endpoint is reachable and returns expected release data
The checkver configuration is correct. The pipeline failure appears to have been transient or environment-specific rather than a configuration issue.
| { | ||
| "description": "High-performance, embeddable, polyglot Virtual Machine for JVM-langs (Java, Scala, Kotlin), JavaScript/NodeJS, Python, Ruby, R, and LLVM-langs (C, C++, Rust)", | ||
| "version": "25.0.1", | ||
| "homepage": "https://www.graalvm.org/", | ||
| "license": "GPL-2.0", | ||
| "url": "https://github.com/graalvm/graalvm-ce-builds/releases/download/jdk-25.0.1/graalvm-community-jdk-25.0.1_windows-x64_bin.zip", | ||
| "hash": "fde83c5ceec2c75560c747ccd9f314f90e4cf5c5287416e67c4ce442e344ca27", | ||
| "extract_to": "tmp", | ||
| "installer": { | ||
| "script": [ | ||
| "(Get-ChildItem -Directory \"$dir\\tmp\").FullName | % { Move-Item \"$_\\*\" \"$dir\" }", | ||
| "Remove-Item -Recurse \"$dir\\tmp\"" | ||
| ] | ||
| }, | ||
| "env_add_path": "bin", | ||
| "env_set": { | ||
| "JAVA_HOME": "$dir", | ||
| "GRAALVM_HOME": "$dir" | ||
| }, | ||
| "checkver": { | ||
| "github": "graalvm/graalvm-ce-builds", | ||
| "regex": "jdk-(25[\\d.]+)" | ||
| }, | ||
| "autoupdate": { | ||
| "url": "https://github.com/graalvm/graalvm-ce-builds/releases/download/jdk-$version/graalvm-community-jdk-$version_windows-x64_bin.zip", | ||
| "hash": { | ||
| "url": "$url.sha256" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: Scope mismatch—manifest implements Community Edition instead of Oracle Edition as requested.
PR objectives specify adding "graalvm-oracle-25jdk" (GraalVM Oracle 25) per issue #565, which provides explicit Oracle-hosted metadata and download URLs. This manifest instead implements GraalVM Community Edition from the GitHub Community builds repository.
Issue #565 criteria require:
- Download from Oracle:
https://download.oracle.com/graalvm/25/latest/graalvm-jdk-25_windows-x64_bin.zip - Homepage:
https://docs.oracle.com/en/graalvm/jdk/25/index.html - Oracle license information reference
Manifest currently specifies:
- Community Edition from GitHub:
graalvm-ce-builds(line 21, 25) - Generic homepage:
https://www.graalvm.org/(line 4) - GPL-2.0 license (line 5), appropriate for Community Edition but not the Oracle edition requested
Please confirm whether the intent is to add Oracle Edition (per issue #565) or Community Edition. If Oracle Edition is intended, align all metadata (homepage, download URL, license) with the issue requirements. If Community Edition is intentional, the issue resolution should be re-filed or clarified.
🧰 Tools
🪛 GitHub Actions: Pull Requests
[error] 1-1: Checkver failed. URL graalvm/graalvm-ce-builds/releases/latest is not valid.
🤖 Prompt for AI Agents
In bucket/bucket/graalvm25.json around lines 1-30: this manifest currently
targets GraalVM Community Edition (GitHub CE build URL, GPL-2.0 license, generic
homepage) but the PR requested GraalVM Oracle Edition; update the manifest to
point to Oracle-hosted release metadata: replace "homepage" with
https://docs.oracle.com/en/graalvm/jdk/25/index.html, replace "url" with
https://download.oracle.com/graalvm/25/latest/graalvm-jdk-25_windows-x64_bin.zip,
update "license" to reference the Oracle/GraalVM Oracle edition license, update
"hash" to the Oracle ZIP SHA256, remove or change the GitHub-based "checkver"
block to use Oracle's version source (or a regex matching Oracle naming), and
adjust "autoupdate" URL to the Oracle pattern
(https://download.oracle.com/graalvm/25/latest/graalvm-jdk-$version_windows-x64_bin.zip)
so all metadata and update checks consistently reference the Oracle
distribution.
Add graalvm25.json for GraalVM 25.0.1
Closes #565
Relates to #XXXX
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.