modern7z: Enhance manifest description, licensing metadata, and installation logic #7475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refines the
modern7zmanifest to improve metadata quality and significantly harden codec-installation logic by resolving the actual7z.exelocation and managing theCodecsdirectory directly.Related issues or pull requests
Changes
descriptionfor precision and technical completenesslicensefield with identifier and terms-of-use URL32/64directories after deploymentinstaller.scriptto:7z.exepath dynamicallyCodecsdirectoryuninstaller.scriptto:7z.exepersistdirNotes
persistdirfunction is only applicable when 7-Zip is installed via Scoop and cannot accommodate scenarios where users enableuse_external_7zip. Moreover, the installation location depends on the installation path of 7-Zip, meaning that the value of$globalmust be consistent at installation time.scoop which 7z, if7zcannot be found through thePathenvironment variable, it will unavoidably output:'7z' not found, not a scoop shim, or a broken shim.Get-CommandPath -Command '7z.exe'.https://github.com/ScoopInstaller/Extras/blob/058e9652b53bb7d361620ed10cf0a26ed64c0ec7/bucket/asar7z.json#L8-L13
Testing
The test results are as follows:
<manifest-name[@version]|chore>: <general summary of the pull request>