-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
7zip: Refine manifest metadata, context-menu handling, and (un)installer scripts #7476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
All changes look good. Wait for review from human collaborators. 7zip
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. 7zip
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. 7zip
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. 7zip
|
| "uninstaller": { | ||
| "script": [ | ||
| "if ($cmd -eq 'uninstall') { reg import \"$dir\\uninstall-context.reg\" *> $null }", | ||
| "Stop-Process -Name 'explorer' -Force -ErrorAction SilentlyContinue", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we always uninstall the association and stop the explorer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uninstall the association
The context menu is unregistered only when $cmd is set to uninstall. The logic may need to be adjusted when no_junction is true, but since most manifests do not account for this case, I do not believe a change is necessary at this time.
stop the explorer
Because 7-Zip uses CLSIDs when registering context menu entries, updates or uninstalls may fail due to files being in use if explorer is not stopped. As most users who install 7-Zip are likely to enable the context menu integration, I believe it is unnecessary to explicitly check whether the context menu is registered, and stopping explorer directly is sufficient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, if the user has registered file associations, uninstalling via Scoop does not currently remove the associated settings. Should .reg files be provided to manage and clean up file associations?
Summary
Refines the
7zipmanifest to improve accuracy, reliability of context-menu registration, and clarity of metadata, while aligning the structure with current Scoop best practices.Related issues or pull requests
Changes
licensestring with structured SPDX identifiers and license URLnotesentry to provide clearer instructions for context-menu registrationpost_installto:.regtemplates$global{{7zip_dir}}placeholder in templates7-zip.chmhelp fileuninstaller.scriptto importuninstall-context.regautomatically on uninstallNotes
Testing
The test results are as follows:
<manifest-name[@version]|chore>: <general summary of the pull request>