-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
rumdl: Add version 0.0.212 #7332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All changes look good. Wait for review from human collaborators. rumdl
|
|
CC @HUMORCE |
|
@Lutra-Fs how come you're requesting a package request issue? Isn't a PR from a maintainer request enough? |
|
/verify |
|
All changes look good. Wait for review from human collaborators. rumdl
|
|
@Lutra-Fs I've linked to the package request. |
|
This is the package request @stevehipwell: #7445. |
|
Thanks @o-l-a-v I had added the link but not removed all of the comment marker so it was hidden. |
Lutra-Fs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you suggest vcredist2022 as well? otherwise it will fail to run on a machine without VC++ runtime
|
Otherwise LGTM |
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@Lutra-Fs done. |
|
Thanks for the contribution and for your patience on this one. Sorry about the review delay. Appreciate you following up |
Add support for rumdl.
Closes #7445
<manifest-name[@version]|chore>: <general summary of the pull request>