-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
claude-code: Add version 2.1.12 #7489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with claude-code
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. claude-code
|
|
@zeldrisho, let's collaborate on this one. I'll close my issue (ScoopInstaller/Extras#16947) and PR (ScoopInstaller/Extras#16948) in the Can I make a few suggestions? 1. Disable auto-update ...
"env_set": {
"DISABLE_AUTOUPDATER": "1"
},
...2. Get hash checksum from the ...
"autoupdate": {
"architecture": {
"64bit": {
"url": "https://storage.googleapis.com/claude-code-dist-86c565f3-f756-42ad-8dfa-d59b1c096819/claude-code-releases/$version/win32-x64/claude.exe",
"hash": {
"url": "https://storage.googleapis.com/claude-code-dist-86c565f3-f756-42ad-8dfa-d59b1c096819/claude-code-releases/$version/manifest.json",
"jsonpath": "$.platforms.win32-x64.checksum"
}
}
}
}
...3. Suggest ...
"suggest": {
"Git": "main/git"
},
...4. Include the license URL ...
"license": {
"identifier": "Proprietary",
"url": "https://github.com/anthropics/claude-code/blob/main/LICENSE.md"
},
...Let me know if you prefer that I raise a PR against your fork. Or if you prefer to incorporate these yourself. Hope we can get Claude Code officially in the |
|
@oddrationale There is no need for DISABLE_AUTOUPDATER because claude-code can't auto-update when installed via Scoop |
|
@zeldrisho, thanks for being open to feedback! Regarding But if it is set, then I think the auto-update feature works by checking for the latest version and running Also, if you install using Homebrew on Mac/Linux, the auto-updater is disabled. So would make sense to do the same thing with |
Co-authored-by: z-Fng <[email protected]>
Relying on the We might benefit from #7459:
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. claude-code
|
z-Fng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@o-l-a-v @zeldrisho @oddrationale Thank you all for your contribution!
Closes #7118, ScoopInstaller/Extras/issues/16947
Relates to #7261