cygwin: Switch to version-specific URLs, add autoupdate hash#7641
Open
SorYoshino wants to merge 2 commits intoScoopInstaller:masterfrom
Open
cygwin: Switch to version-specific URLs, add autoupdate hash#7641SorYoshino wants to merge 2 commits intoScoopInstaller:masterfrom
SorYoshino wants to merge 2 commits intoScoopInstaller:masterfrom
Conversation
Contributor
|
All changes look good. Wait for review from human collaborators. cygwin
|
Contributor
Author
|
/verify |
Contributor
|
All changes look good. Wait for review from human collaborators. cygwin
|
Contributor
Author
|
The behavior of ┏[ D:\Software\Scoop\Local\apps\scoop\current\bin][ develop ≡]
└─> cygwin-setup --version | Write-Output
Cygwin setup 2.936During the installation or update of {
"notes": [
"Due to the specific output behavior of `cygwin-setup.exe`, executing `cygwin-setup <option>` directly in a terminal may not display any output.",
"To display the corresponding output, use a pipe to forward the result to the console.",
"In PowerShell, execute `cygwin-setup <option> | Write-Output` to display the output.",
"In Command Prompt (cmd), execute `cygwin-setup <option> | more` to display the output."
]
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the
cygwinmanifest to implement version-specific hash extraction and improves persistence logic for better reliability across different architectures.Related issues or pull requests
Changes
autoupdateto parsesha512.sumdynamically.hashfield to ensure the 64-bit hash is matched againstsetup-$version.x86_64.exeand the 32-bit hash againstsetup-$version.x86.exe.persist_permissionto maintain Cygwin's critical POSIX file attributes.installerscript withensurechecks.Cygwinsubfolder and added--upgrade-alsoto the installation arguments.Notes
When a new version is detected, the version referenced by the previous download link may not necessarily be the latest, which has led to a large number of related issues.
A comparison of the shortlog and tags shows that the binary files for the latest release are published some time before the corresponding information appears in the tags. Since it is unclear how long after the shortlog is published the corresponding version becomes available at the release URL, the release URL is used as the
checkversource to avoid auto-update failures.Use the
--upgrade-alsooption in theinstallerscript to ensure the installed application is upgraded to the latest version simultaneously. Add the--no-version-checkoption to theCygwin Setupshortcut to prevent version update prompts during use. The options used in this PR are explained as follows:Testing
The test results are as follows:
<manifest-name[@version]|chore>: <general summary of the pull request>