nelson-np: Add version 1.16.0.5575 #505
Conversation
WalkthroughAdds a new Scoop nonportable manifest Changes
Sequence Diagram(s)(omitted — changes do not introduce multi-component control flow requiring a sequence diagram) Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with nelson-np
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/nelson-np.json(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Pull Requests
bucket/nelson-np.json
[warning] 1-1: Checkver: could not match version string on Nelson manifest website (Checkver: False).
🔇 Additional comments (2)
bucket/nelson-np.json (2)
6-11: Verify version string format in autoupdate context.Line 18 uses
$versionin the autoupdate URL, but the manifest structure only defines$majorVersion,$minorVersion, and$patchVersion. Confirm that Scoop's autoupdate mechanism correctly constructs the full version string (including the build number.5475) from these components, or explicitly define the version format.
14-14: File bucket/nelson-np.json no longer exists in the repository.The file referenced in this review has been deleted from the repository (it was last present in commit d8eb949). Since the file under review does not exist in the current codebase, this review comment cannot be applied.
Likely an incorrect or invalid review comment.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/nelson-np.json(1 hunks)
🔇 Additional comments (3)
bucket/nelson-np.json (3)
15-21: Verify autoupdate variable expansion with corrected version.The autoupdate URL template uses
$majorVersion.$minorVersion.$patchVersionand$versionvariables. Once the version field is corrected to1.15.0.5475, verify that Scoop correctly expands these variables:
- Expected expansion:
v1.15.0.5475in the GitHub tag and1.15.0.5475in the filename.- For versions with four numeric segments (1.15.0.5475), confirm Scoop treats
5475as the$patchVersionor if you need a different variable pattern.You may want to test autoupdate by running
scoop update nelson-npafter deployment or verify against Scoop's documentation for four-part version handling.
6-13: Installation and uninstallation scripts look good.The architecture block, SHA256 hash, and PowerShell scripts for post_install and pre_uninstall are correctly formatted. The silent installation flags and cleanup steps are appropriate for a Windows Inno Setup-based installer.
1-1: Metadata and version checking are properly configured.The JSON structure, homepage, description, license, and checkver method are all correct and well-formed. The checkver="github" configuration is appropriate for automatic version detection from GitHub releases.
Also applies to: 3-5, 14-14
|
This is my first Scoop manifest. Apologies if I made any mistakes or didn’t follow the proper submission process. |
SorYoshino
added
the
package-request-needed
|
To add a new package to this bucket, please follow the standard way to create a package request issue first and link it to your PR. When creating a package request, you can check the criteria for a package to be accepted in this bucket, which can help you determine whether your PR is likely to be approved. The information provided in the issue can also help maintainers quickly get the necessary details.
|
https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests#required-properties
Please add the
Please carefully review the Contributing Guide and the App Manifest Autoupdate documentation, then update the App Manifest accordingly. |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@bucket/nelson-np.json`:
- Around line 35-38: The autoupdate "url" entries in nelson-np.json for the
x86_64 and arm64 assets currently point to "Nelson-$version-...exe" and are
missing the download fragment that renames the file to setup.exe; update both
"url" values to append the fragment "#/setup.exe" so the downloaded file is
renamed to setup.exe (ensuring the installer script that runs "$dir\\setup.exe"
will find the file).
- Line 31: The current checkver: "github" returns the tag-only version (e.g.,
v1.16.0) while assets include the build number (e.g.,
Nelson-1.16.0.5575-x86-64.exe), causing autoupdate to request a non-existent
filename; replace the simple "github" checkver with a custom checkver that
parses asset filenames (or use asset-based detection) and a regex that extracts
the full four-part version (major.minor.patch.build) from asset names, then
ensure the autoupdate rule uses $version matching that extracted value so
downloads request the correct asset; update the manifest's checkver and
autoupdate entries accordingly (look for the "checkver" key and the autoupdate
template).
♻️ Duplicate comments (1)
bucket/nelson-np.json (1)
16-31: Addshortcutsorbinper app UX (still missing).The manifest still lacks
shortcuts(GUI) orbin(CLI). Please confirm the intended UX and add the appropriate entry per repo guidelines.
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with nelson-np
|
|
I also created an issue: #534 |
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with nelson-np
|
Understood. The current manifest has some issues, and I am in the process of addressing them. |
Nelson-numerical-software
changed the title
|
/verify |
SorYoshino
removed
the
package-request-needed
|
All changes look good. Wait for review from human collaborators. nelson-np
|
|
Thanks for your help @SorYoshino |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@bucket/nelson-np.json`:
- Around line 31-35: The checkver regex in the "checkver" block currently
captures the version as an unnamed group, which can break Scoop autoupdate
mappings; update the "regex" value so the version capture is explicitly named
`(?<version>...)` (i.e., change the group that matches the numeric version in
the regex used in the "checkver" object) so `$version` will reliably map to the
captured build number for autoupdate.
♻️ Duplicate comments (1)
bucket/nelson-np.json (1)
2-18: Consider addingshortcutsorbinfor discoverability.There’s no launch entry, so users must manually navigate into the install dir. Please confirm whether Nelson should expose a GUI shortcut or CLI
binentry and add the appropriate field. Line 2–18.
|
/verify |
|
All changes look good. Wait for review from human collaborators. nelson-np
|
|
Thanks for your contribution! The manifest will update automatically as the package updates, as long as the upstream releases new packages that follow the same pattern defined in the manifest. If there are any other changes, feel free to submit a PR. |
SorYoshino
changed the title
2 participants
Summary
Add a manifest for nelson-np version 1.16.0.5575.
Related issues or pull requests
Testing
scoop install nelson-npworks without errorsnelson.exelaunches successfullyscoop uninstall nelson-npremoves all installed filesSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.