VSCode - Don't create .sln project file automatically + some other settings changes#6493
VSCode - Don't create .sln project file automatically + some other settings changes#6493o-l-a-v wants to merge 4 commits intoScoopInstaller:developfrom
.sln project file automatically + some other settings changes#6493Conversation
WalkthroughUpdates to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
.sln project file automatically.sln project file automatically + some other settings changes
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.vscode/settings.json (1)
2-5: Fix typo; optionally set default formatter for PowerShell.
- Typo: “constistency” → “consistency”.
- Optional: ensure the PowerShell formatter is used on save.
- // Apply formatting on save for constistency + // Apply formatting on save for consistency "[powershell]": { - "editor.formatOnSave": true + "editor.formatOnSave": true, + "editor.defaultFormatter": "ms-vscode.powershell" },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.vscode/settings.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (3)
.vscode/settings.json (3)
17-18: LGTM: final newline on save.Good editor hygiene; complements inconsistent .editorconfig cases.
20-27: Confirm PSScriptAnalyzer settingsPath: File exists at../PSScriptAnalyzerSettings.psd1relative to.vscode; settingsPath is correct.
6-7: No changes needed: “dotnet.automaticallyCreateSolutionInWorkspace” is correct and provided by the C# Dev Kit extension to disable automatic .sln creation.
Description
settings.jsonto not create.slnproject file automatically.{ "dotnet.automaticallyCreateSolutionInWorkspace": false }settings.json."[powershell]": {"editor.formatOnSave": true}for consistency, else why specify formatting settings in.vscode/settings.json?"files.insertFinalNewline": true, because EditorConfig did not seem to apply that consistently.Motivation and Context
Closes #6492
How Has This Been Tested?
It's just a small VSCode settings change.
Checklist:
developbranch.Summary by CodeRabbit