-
-
Notifications
You must be signed in to change notification settings - Fork 24
Update all dependencies to latest versions and fix several linter issues #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
9f1740e
Update to Node 24
gpailler 17e4fa6
Replace npm with pnpm
gpailler 1568b10
Update typescript to latest 5.9.3
gpailler e900124
Update vite to latest 7.2.4
gpailler 38395c7
Update from eslint/prettier to latest biome 2.3.7
gpailler 1e4943d
Biome: format
gpailler 6f3f91e
Biome: lint:fix
gpailler 29f31b1
Update react to latest 19.2.0 + update all react dependencies
gpailler 60cdd6b
Update remaining small dependencies to the latest version
gpailler 922787a
Move some dependencies to dev
gpailler 1c7e619
Switch to maintained @dr.pogodin/react-helmet to fix an error in the …
gpailler 5a0537c
Fix several issues in Buckets.tsx to properly display the buckets wit…
gpailler 19a80c7
Biome linter fix: Useless React Fragments
gpailler e0031f2
Biome linter fix: Static-only class
gpailler 3b014e3
Biome linter fix: Double equals (== vs ===)
gpailler 3488ec8
Biome linter fix: Reorder usings
gpailler f8aeca0
Biome linter fix: Missing radix parameter in parseInt
gpailler 4e299b6
Biome linter fix: String template preference
gpailler 94ec2cf
Biome linter fix: Add noDangerouslySetInnerHtml exception
gpailler 723017a
Biome linter fix: Array index as key
gpailler 8b169fb
Remove remaining eslint ignore comments
gpailler 78d078e
Fix errors reported in the console when opening search options
gpailler 597d53a
Biome linter fix: Fixing CSS descending specificity error
gpailler 740aa51
Biome linter fix: fix both ColorSchemeProvider issues by moving the t…
gpailler 5369d4c
Biome linter fix: move sortResults outside the component (since it do…
gpailler 8ff6b50
Biome linter fix: Wrap clearDelayBeforeSubmitTimeout in useCallback a…
gpailler 5bab906
Biome linter fix: Fix any type in request-idle-callback.ts + fix unus…
gpailler d2d6775
Biome linter fix: idleCallbackId is a ref and doesn't need to be in t…
gpailler c9576e8
Bump version to 0.2.1
gpailler 7f3832e
Replace setSortIndex with setSortDirection (wrong copy/paste)
gpailler 981eddc
Don't mutate the original array and return a sorted copy instead
gpailler 665bb71
Move recommended extension in the customizations/vscode section
gpailler 6247fe1
Use --frozen-lockfile on CI to strictly honor the lockfile
gpailler 399f160
Wrap state updates in useEffect hooks to prevents potential issues wi…
gpailler 2654bb9
Perform local sort of the buckets
gpailler 1b821ae
Split bundle in chunks to allow parallel download by the browser
gpailler 646b20e
Remove unused abortControllerRef
gpailler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1,24 @@ | ||
| { | ||
| "name": "ScoopInstaller web frontend (Node.js & TypeScript)", | ||
| // Use TypeScript + Node 16 | ||
| "image": "mcr.microsoft.com/devcontainers/typescript-node:16", | ||
| "forwardPorts": [ | ||
| 3000 | ||
| ], | ||
| "portsAttributes": { | ||
| "3000": { | ||
| "label": "Vite dev server", | ||
| "onAutoForward": "openBrowser" | ||
| } | ||
| }, | ||
| "extensions": [ | ||
| "dbaeumer.vscode-eslint" | ||
| ], | ||
| "customizations": { | ||
| "codespaces": { | ||
| "openFiles": [ | ||
| "src/App.tsx" | ||
| ] | ||
| } | ||
| }, | ||
| // Install required modules | ||
| "updateContentCommand": "npm ci", | ||
| // Start dev server | ||
| "postAttachCommand": "npm run dev" | ||
| } | ||
| "name": "ScoopInstaller web frontend (Node.js & TypeScript)", | ||
| // Use TypeScript + Node 24 | ||
| "image": "mcr.microsoft.com/devcontainers/typescript-node:24", | ||
| "forwardPorts": [3000], | ||
| "portsAttributes": { | ||
| "3000": { | ||
| "label": "Vite dev server", | ||
| "onAutoForward": "openBrowser" | ||
| } | ||
| }, | ||
| "customizations": { | ||
| "vscode": { | ||
| "extensions": ["biomejs.biome"] | ||
| }, | ||
| "codespaces": { | ||
| "openFiles": ["src/App.tsx"] | ||
| } | ||
| }, | ||
| // Install required modules | ||
| "updateContentCommand": "corepack enable && pnpm install --frozen-lockfile", | ||
| // Start dev server | ||
| "postAttachCommand": "pnpm run dev" | ||
| } |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 24 |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| { | ||
| "$schema": "https://biomejs.dev/schemas/2.3.7/schema.json", | ||
| "vcs": { | ||
| "enabled": true, | ||
| "clientKind": "git", | ||
| "useIgnoreFile": true | ||
| }, | ||
| "files": { | ||
| "ignoreUnknown": false | ||
| }, | ||
| "formatter": { | ||
| "enabled": true, | ||
| "indentStyle": "space", | ||
| "indentWidth": 2, | ||
| "lineWidth": 120 | ||
| }, | ||
| "linter": { | ||
| "enabled": true, | ||
| "rules": { | ||
| "recommended": true, | ||
| "style": { | ||
| "noNonNullAssertion": "warn", | ||
| "useImportType": "warn" | ||
| }, | ||
| "complexity": { | ||
| "noExcessiveCognitiveComplexity": "off", | ||
| "noImportantStyles": "off", | ||
| "noArguments": "off" | ||
| }, | ||
| "correctness": { | ||
| "useExhaustiveDependencies": "warn" | ||
| }, | ||
| "suspicious": { | ||
| "noExplicitAny": "warn" | ||
| }, | ||
| "a11y": { | ||
| "recommended": true, | ||
| "useKeyWithClickEvents": "off", | ||
| "useKeyWithMouseEvents": "off", | ||
| "noStaticElementInteractions": "off" | ||
| } | ||
| } | ||
| }, | ||
| "javascript": { | ||
| "formatter": { | ||
| "quoteStyle": "single", | ||
| "semicolons": "always", | ||
| "trailingCommas": "es5" | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify accessibility rule disablement.
Three accessibility rules are explicitly disabled:
useKeyWithClickEvents,useKeyWithMouseEvents, andnoStaticElementInteractions. For a web project, disabling these rules is a significant regression in accessibility compliance. Confirm this is intentional and not a workaround to silence violations during migration.If this was disabled due to existing violations in the codebase, consider re-enabling these rules and addressing the violations to maintain or improve accessibility posture.
🏁 Script executed:
Length of output: 1183
Address disabled accessibility rules in biome.json.
Three accessibility rules are explicitly disabled (lines 38-40):
useKeyWithClickEvents,useKeyWithMouseEvents, andnoStaticElementInteractions. This directly contradicts the"recommended": truesetting within the a11y section and represents a regression for a web project. Additionally, the cognitive complexity rule is disabled (noExcessiveCognitiveComplexity: "off" at line 26), and several other rules are downgraded to "warn" level.Either document the business/technical justification for these exemptions, or re-enable these rules and address the underlying violations to maintain accessibility posture.
🤖 Prompt for AI Agents