Skip to content

n-02: use calldata instead of memory#84

Closed
thelostone-mc wants to merge 1 commit intoaudit-fixesfrom
n-02
Closed

n-02: use calldata instead of memory#84
thelostone-mc wants to merge 1 commit intoaudit-fixesfrom
n-02

Conversation

@thelostone-mc
Copy link
Copy Markdown
Contributor

No description provided.

@thelostone-mc
Copy link
Copy Markdown
Contributor Author

image

From @wildmolasses

This change adds about 10000 gas to the gas cost on most non-reverting propose, queue, cancel, execute calls. generally, calldata params cost less than memory. but our issue is that we're then pulling these calldata params into memory anyway, so we're doing extra. That's like 99% of the tests where there's a diff. green is savings w/ memory over calldata

@github-actions
Copy link
Copy Markdown

Coverage after merging n-02 into audit-fixes will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   RollbackManager.sol100%100%100%100%
   RollbackManagerTimelockCompound.sol100%100%100%100%
   RollbackManagerTimelockControl.sol100%100%100%100%
   TimelockMultiAdminShim.sol100%100%100%100%

@thelostone-mc thelostone-mc added the wontfix This will not be worked on label Aug 26, 2025
@thelostone-mc
Copy link
Copy Markdown
Contributor Author

Closing as auditors agree this is issue is not valid

@thelostone-mc thelostone-mc deleted the n-02 branch August 26, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discuss with oz wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant