m-03-audit: ensure to send only msg.value and not balance#85
Merged
thelostone-mc merged 1 commit intoaudit-fixesfrom Aug 28, 2025
Merged
m-03-audit: ensure to send only msg.value and not balance#85thelostone-mc merged 1 commit intoaudit-fixesfrom
thelostone-mc merged 1 commit intoaudit-fixesfrom
Conversation
thelostone-mc
force-pushed
the
timelock-eth-test
branch
from
cccd113 to
670e43d
Compare
thelostone-mc
force-pushed
the
m-03-fix
branch
from
a88386f to
f08be8c
Compare
thelostone-mc
force-pushed
the
m-03-fix
branch
from
f08be8c to
026287d
Compare
|
Coverage after merging m-03-fix into audit-fixes will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||
thelostone-mc
commented
Aug 29, 2025
| ) public payable nonReentrant returns (bytes memory) { | ||
| _revertIfNotAdminOrExecutor(); | ||
| return TIMELOCK.executeTransaction{value: address(this).balance}(_target, _value, _signature, _data, _eta); | ||
| return TIMELOCK.executeTransaction{value: msg.value}(_target, _value, _signature, _data, _eta); |
Contributor
Author
There was a problem hiding this comment.
Basically OZ is suggesting we use _value instead of msg.value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on feedback