Replace Dapr-based Grace.Server.Tests with Aspire-hosted integration tests#37
Replace Dapr-based Grace.Server.Tests with Aspire-hosted integration tests#37ScottArbeit merged 2 commits intomainfrom
Conversation
… fix for a recursive Repository delete where we also delete the branches.
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .WithEnvironment(EnvironmentVariables.AzureServiceBusNamespace, "sbemulatorns") | ||
| .WithEnvironment(EnvironmentVariables.AzureServiceBusTopic, "graceeventstream") | ||
| .WithEnvironment(EnvironmentVariables.AzureServiceBusSubscription, "grace-server") | ||
| .WithEnvironment(EnvironmentVariables.GraceLogDirectory, logDirectory) | ||
| .WithEnvironment(EnvironmentVariables.DebugEnvironment, "Local"); |
There was a problem hiding this comment.
Grace.Server aborts on startup if GRACE_LOG_DIRECTORY is missing (Program.Server.fs raises an invalidOp when the env var is empty), but the Aspire host now sets this variable only inside the DebugLocal branch. Azure-debug and publish runs skip that branch, so the server will fail to boot in those modes with “Environment variable 'GRACE_LOG_DIRECTORY' must be set…”. Please provide GRACE_LOG_DIRECTORY for the non-local configurations as well.
Useful? React with 👍 / 👎.
1 participant
Satisfies requirements in feature specification in issue #36.