Fix grace connect end-to-end (bootstrap config + real download + version selection)#49
Fix grace connect end-to-end (bootstrap config + real download + version selection)#49ScottArbeit merged 24 commits intomainfrom
grace connect end-to-end (bootstrap config + real download + version selection)#49Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b98568e8e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let private tryGetOidcCliConfigFromServer (correlationId: string) = | ||
| task { | ||
| match tryGetEnv Constants.EnvironmentVariables.GraceServerUri with | ||
| | None -> return Ok None |
There was a problem hiding this comment.
The new server-based OIDC lookup bails out if GRACE_SERVER_URI is not set (tryGetOidcCliConfigFromServer returns Ok None). That means a typical flow like grace connect --server-address ... (which writes ServerUri into graceconfig.json but does not set the env var) will still fail grace auth login with “Authentication is not configured,” even though the server can supply the OIDC config. This is a regression for the intended “connect end-to-end” flow because users will have to manually set GRACE_SERVER_URI to make the new server-based config path work. Consider falling back to Current().ServerUri (and/or updating Grace.SDK.Auth.getOidcClientConfig to use it) when the env var is absent.
Useful? React with 👍 / 👎.
1 participant
Resolves #48.