Fix tokenizer loading for GPT2 #757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #752 Fix the issue with loading the tokenizer for 'gpt2'. * **scrapegraphai/utils/tokenizer.py** - Add a check for `GPT2TokenizerFast` in the `num_tokens_calculus` function. - Import `GPT2TokenizerFast` from `transformers`. * **scrapegraphai/utils/tokenizers/tokenizer_ollama.py** - Modify the `num_tokens_ollama` function to handle `GPT2TokenizerFast`. * **tests/graphs/smart_scraper_ollama_test.py** - Add a test case to verify the tokenizer loading for `GPT2TokenizerFast`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/ScrapeGraphAI/Scrapegraph-ai/issues/752?shareId=XXXX-XXXX-XXXX-XXXX).
VinciGit00
reviewed
Oct 17, 2024
Collaborator
There was a problem hiding this comment.
thank you for the test
Collaborator
There was a problem hiding this comment.
never seen before thank you
VinciGit00
approved these changes
Oct 18, 2024
|
🎉 This PR is included in version 1.26.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Collaborator
|
Hi |
|
🎉 This PR is included in version 1.27.0-beta.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #752
Fix the issue with loading the tokenizer for 'gpt2'.
scrapegraphai/utils/tokenizer.py
GPT2TokenizerFastin thenum_tokens_calculusfunction.GPT2TokenizerFastfromtransformers.scrapegraphai/utils/tokenizers/tokenizer_ollama.py
num_tokens_ollamafunction to handleGPT2TokenizerFast.tests/graphs/smart_scraper_ollama_test.py
GPT2TokenizerFast.For more details, open the Copilot Workspace session.