Skip to content

Conversation

@cobaltt7
Copy link
Contributor

I just made these use strings so they can be extended in the future without updating the schema.
Should fix SA/SA CI.

@Samq64
Copy link
Member

Samq64 commented Apr 25, 2025

I think presetPreview should keep full validation since it doesn't just take an addon ID like addonPreview does.

Now that I think about it might make more sense for addonPreview to just be a boolean, but that's another issue.

@Samq64
Copy link
Member

Samq64 commented May 2, 2025

@cobaltt7 Do you mind of I push to this branch?

@cobaltt7
Copy link
Contributor Author

cobaltt7 commented May 2, 2025

go ahead

@Samq64
Copy link
Member

Samq64 commented May 2, 2025

The 2nd commit is for ScratchAddons/ScratchAddons#6104 and ScratchAddons/ScratchAddons#7941.

@Samq64 Samq64 changed the title Remove addonPreview/presetPreview enums Update presetPreview, add relatedAddons, remove popup html/script May 2, 2025
@Samq64 Samq64 changed the title Update presetPreview, add relatedAddons, remove popup html/script Update previews, add relatedAddons, remove popup script/html May 2, 2025
@Samq64 Samq64 merged commit 52d7ef1 into ScratchAddons:master May 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants