Skip to content

[WIP] Update footer to display 备案信息 and refactor author display#5

Merged
SeRazon merged 1 commit intodevfrom
copilot/update-footer-component-beian
Oct 17, 2025
Merged

[WIP] Update footer to display 备案信息 and refactor author display#5
SeRazon merged 1 commit intodevfrom
copilot/update-footer-component-beian

Conversation

Copy link

Copilot AI commented Oct 17, 2025

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.

Original prompt

Please update the existing PR to ensure the 备案信息 displays in the actual site footer component and remove the hardcoded author span.

Changes to make:

  1. Keep the reusable component and ensure it exists at src/components/BeianBlock.vue (use the implementation we discussed: icon + text inline-flex with 16px size, props policeText, policeLink, icpText, icpLink, iconSrc and scoped CSS).

  2. Integrate BeianBlock into the global footer component that the app actually renders: src/components/Footer.vue

    • Import BeianBlock and render it at the top of the power section so it shows in the footer by default.
    • Remove the original hardcoded span containing the text "星鸿_SeRazon" and move the copyright block below the BeianBlock.
    • Replace the old block that conditionally showed only ICP with the BeianBlock.
    • Keep year, author, site URL logic, but without the hardcoded string; show it under the 备案信息.
    • Keep the existing v-if condition for lyrics; if the user later wants备案信息 to always show (even when lyrics are showing), we can move it outside the v-if.
  3. Remove any extra footer added to src/App.vue that duplicates the footer (if present). The app should only have the single, centralized src/components/Footer.vue controlling the footer.

  4. Build should pass on dev and the footer should display: [公安图标] 赣公网安备36012202000590号 | 赣ICP备2025074193号, then the copyright line below it.

  5. Do not add binary assets to the repo; default to the official icon URL. Users can later switch to /gongan.png by passing icon-src.

Acceptance criteria:

  • Footer.vue uses and the old hardcoded span with "星鸿_SeRazon" is removed.
  • App.vue no longer adds its own footer; render duplication is avoided.
  • Visual alignment of icon/text is correct.
  • Links open in a new tab and point to the provided URLs.

This pull request was created as a result of the following prompt from Copilot chat.

Please update the existing PR to ensure the 备案信息 displays in the actual site footer component and remove the hardcoded author span.

Changes to make:

  1. Keep the reusable component and ensure it exists at src/components/BeianBlock.vue (use the implementation we discussed: icon + text inline-flex with 16px size, props policeText, policeLink, icpText, icpLink, iconSrc and scoped CSS).

  2. Integrate BeianBlock into the global footer component that the app actually renders: src/components/Footer.vue

    • Import BeianBlock and render it at the top of the power section so it shows in the footer by default.
    • Remove the original hardcoded span containing the text "星鸿_SeRazon" and move the copyright block below the BeianBlock.
    • Replace the old block that conditionally showed only ICP with the BeianBlock.
    • Keep year, author, site URL logic, but without the hardcoded string; show it under the 备案信息.
    • Keep the existing v-if condition for lyrics; if the user later wants备案信息 to always show (even when lyrics are showing), we can move it outside the v-if.
  3. Remove any extra footer added to src/App.vue that duplicates the footer (if present). The app should only have the single, centralized src/components/Footer.vue controlling the footer.

  4. Build should pass on dev and the footer should display: [公安图标] 赣公网安备36012202000590号 | 赣ICP备2025074193号, then the copyright line below it.

  5. Do not add binary assets to the repo; default to the official icon URL. Users can later switch to /gongan.png by passing icon-src.

Acceptance criteria:

  • Footer.vue uses and the old hardcoded span with "星鸿_SeRazon" is removed.
  • App.vue no longer adds its own footer; render duplication is avoided.
  • Visual alignment of icon/text is correct.
  • Links open in a new tab and point to the provided URLs.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@vercel
Copy link

vercel bot commented Oct 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
home Ready Ready Preview Comment Oct 17, 2025 4:32pm

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

@SeRazon SeRazon marked this pull request as ready for review October 17, 2025 16:33
@SeRazon SeRazon merged commit aad3a4d into dev Oct 17, 2025
5 of 6 checks passed
Copilot AI requested a review from SeRazon October 17, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants