Skip to content

[WIP] Finalize footer implementation for ICP and公安备案信息#7

Merged
SeRazon merged 1 commit intodevfrom
copilot/finalize-footer-implementation
Oct 17, 2025
Merged

[WIP] Finalize footer implementation for ICP and公安备案信息#7
SeRazon merged 1 commit intodevfrom
copilot/finalize-footer-implementation

Conversation

Copy link

Copilot AI commented Oct 17, 2025

  • Create BeianBlock.vue component with props for police/ICP 备案信息
  • Add 公安备案 icon (16x16px) to public/images/icon directory
  • Update Footer.vue to import and use BeianBlock component
  • Remove hardcoded "星鸿_SeRazon" text from Footer.vue
  • Remove unused config import from Footer.vue
  • Test and validate the implementation
  • Run linter to ensure code quality
Original prompt

Finalize the footer implementation to display ICP/公安备案信息 and clean up legacy footer text. This PR should be ready for merge (no WIP).

Implement the following concrete changes in SeRazon/home on base branch dev:

  1. Add the reusable BeianBlock component to render the 备案信息 with aligned icon and text.

    • File: src/components/BeianBlock.vue
    • Contents:
      • Template renders: [公安图标] 赣公网安备36012202000590号 | 赣ICP备2025074193号
      • Props: policeText, policeLink, icpText, icpLink, iconSrc (all optional with sensible defaults)
      • CSS: inline-flex alignment, icon fixed 16×16px, subtle separator
  2. Update the real site footer component to use the BeianBlock and remove the hardcoded author span that starts with "星鸿_SeRazon".

    • File: src/components/Footer.vue
    • Import and render at the top of the power section so备案信息显示在页脚。
    • Remove the old hardcoded span containing "星鸿_SeRazon" and the legacy only-ICP block.
    • Keep and render the year/author/siteUrl info below the备案信息. If siteAuthor is empty, hide the copyright block.
    • Preserve the existing lyrics v-if logic.
  3. Ensure App.vue does not render a second footer.

    • File: src/App.vue
    • Keep only and remove any custom footer to avoid duplication.
  4. Do not add binary assets. Default to the official icon URL (https://www.beian.gov.cn/img/ghs.png). Users can later pass icon-src="/gongan.png" if they add a local icon under public/.

Acceptance criteria:

  • Build passes on dev.
  • Footer displays备案信息 in the real footer: [公安图标] 赣公网安备36012202000590号 | 赣ICP备2025074193号.
  • The previously hardcoded author span is removed from source and the copyright line appears below备案信息.
  • No duplicate footers are rendered.

This pull request was created as a result of the following prompt from Copilot chat.

Finalize the footer implementation to display ICP/公安备案信息 and clean up legacy footer text. This PR should be ready for merge (no WIP).

Implement the following concrete changes in SeRazon/home on base branch dev:

  1. Add the reusable BeianBlock component to render the 备案信息 with aligned icon and text.

    • File: src/components/BeianBlock.vue
    • Contents:
      • Template renders: [公安图标] 赣公网安备36012202000590号 | 赣ICP备2025074193号
      • Props: policeText, policeLink, icpText, icpLink, iconSrc (all optional with sensible defaults)
      • CSS: inline-flex alignment, icon fixed 16×16px, subtle separator
  2. Update the real site footer component to use the BeianBlock and remove the hardcoded author span that starts with "星鸿_SeRazon".

    • File: src/components/Footer.vue
    • Import and render at the top of the power section so备案信息显示在页脚。
    • Remove the old hardcoded span containing "星鸿_SeRazon" and the legacy only-ICP block.
    • Keep and render the year/author/siteUrl info below the备案信息. If siteAuthor is empty, hide the copyright block.
    • Preserve the existing lyrics v-if logic.
  3. Ensure App.vue does not render a second footer.

    • File: src/App.vue
    • Keep only and remove any custom footer to avoid duplication.
  4. Do not add binary assets. Default to the official icon URL (https://www.beian.gov.cn/img/ghs.png). Users can later pass icon-src="/gongan.png" if they add a local icon under public/.

Acceptance criteria:

  • Build passes on dev.
  • Footer displays备案信息 in the real footer: [公安图标] 赣公网安备36012202000590号 | 赣ICP备2025074193号.
  • The previously hardcoded author span is removed from source and the copyright line appears below备案信息.
  • No duplicate footers are rendered.

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copilot AI self-assigned this Oct 17, 2025
@vercel
Copy link

vercel bot commented Oct 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
home Ready Ready Preview Comment Oct 17, 2025 4:43pm

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

@SeRazon SeRazon marked this pull request as ready for review October 17, 2025 16:44
@SeRazon SeRazon merged commit 5cc74c7 into dev Oct 17, 2025
5 of 6 checks passed
Copilot AI requested a review from SeRazon October 17, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants