Open
Conversation
SeaJackal
requested changes
Oct 24, 2025
|
|
||
| public: | ||
| constexpr Thruster(unsigned thruster_tim_channel, | ||
| hydrv::timer::TimerLow &thruster_tim, |
Owner
There was a problem hiding this comment.
Вот это менять не стоило, пусть остаётся ссылками
| hydrolib::controlling::ThrustGenerator<THRUSTERS_COUNT> thrust_generator_; | ||
|
|
||
| private: | ||
| static_assert(hydrolib::controlling::ThrusterConcept<ThrusterControl>, |
Owner
There was a problem hiding this comment.
Не уверен, что это следует писать внутри класса
| class ThrusterControl | ||
| { | ||
| private: | ||
| int x_rotation_gain_[THRUSTERS_COUNT]; |
Owner
There was a problem hiding this comment.
А зачем это хранить здесь? Почему бы не пробросить это сразу в thrust_generator?
| int y_linear_gain_[THRUSTERS_COUNT]; | ||
| int z_linear_gain_[THRUSTERS_COUNT]; | ||
|
|
||
| int dest_[THRUSTERS_COUNT]; |
Owner
There was a problem hiding this comment.
Почему бы эту переменную не сделать временной внутри функции обработки?
| { | ||
| for (int i = 0; i < THRUSTERS_COUNT; i++) | ||
| { | ||
| thrusters_[i](thruster_tim_channel[i], *thruster_tim[i], |
Owner
There was a problem hiding this comment.
Вот это вообще интересная штука, не знал, что так можно. Это точно компилируется?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added hydrv_thrusters_control class v1.0 with dependencies