Add reasoning param to configure LLM instead of max_token#18
Merged
nicolo-rinaldi merged 5 commits intomainfrom Dec 10, 2025
Merged
Add reasoning param to configure LLM instead of max_token#18nicolo-rinaldi merged 5 commits intomainfrom
max_token#18nicolo-rinaldi merged 5 commits intomainfrom
Conversation
All tests passed, didn't yet try the reasoning in the main script
All tests passed and tried some configurations. Now the validation happens at the Pydantic model level
nseidan
requested changes
Dec 10, 2025
src/llm_search_quality_evaluation/dataset_generator/llm/llm_config.py
Outdated
Show resolved
Hide resolved
src/llm_search_quality_evaluation/dataset_generator/llm/llm_config.py
Outdated
Show resolved
Hide resolved
nseidan
reviewed
Dec 10, 2025
src/llm_search_quality_evaluation/dataset_generator/llm/llm_provider_factory.py
Outdated
Show resolved
Hide resolved
nseidan
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed the problem in the related GitHub issues