Add BookService implementation with dummy endpoint#2
Merged
SebastienMelki merged 4 commits intomainfrom Aug 24, 2025
Merged
Conversation
- Add Book message with ID, title, and release year - Add GetBooksRequest and GetBooksResponse messages - Create BookService with GetBooks RPC endpoint - Configure service base path as /api/book/v1 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add BookID typed identifier to core/v1/ids.proto - Update SongService base path to /api/song/v1 for consistency - Prepare for multi-service API structure with versioned paths 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add BookService struct implementing GetBooks RPC - Return sample book data with Arabic translation - Register BookService HTTP handlers on port 8080 - Demonstrate service integration with generated API code 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add BookService OpenAPI specifications (JSON and YAML) - Update SongService API path to /api/song/v1/songs - Generated documentation reflects new service structure 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
New Book service proto definitions
/api/book/v1Core updates
/api/song/v1for consistencyServer implementation
Documentation
Test plan
make generateto verify proto generationmake buildto verify compilation/api/book/v1/booksendpoint🤖 Generated with Claude Code