feat(ts-client): support message-only protos and proto field names#130
Open
feat(ts-client): support message-only protos and proto field names#130
Conversation
🔍 CI Pipeline Status❌ Lint: failure 📊 Coverage Report: Available in checks above |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
========================================
+ Coverage 3.17% 5.10% +1.92%
========================================
Files 47 47
Lines 7485 7732 +247
========================================
+ Hits 238 395 +157
- Misses 7243 7305 +62
- Partials 4 32 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extracts the TypeScript-specific work from #126. Closes #133.
Included here:
protoc-gen-ts-clientfield_names=json|protosupport for TS client outputWhy
These changes are self-contained within the TypeScript generator stack and can be reviewed independently from the new cross-language generators.
What Changed
cmd/protoc-gen-ts-clientinternal/tsclientgeninternal/tscommonTests
env GOTOOLCHAIN=auto go test ./internal/tsclientgenenv GOTOOLCHAIN=auto go build -o bin/protoc-gen-ts-client ./cmd/protoc-gen-ts-client