allow using buildback in CI tests#7
Open
jamemackson wants to merge 4 commits intoSectorLabs:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue we found while attempting to use this buildpack in heroku CI where the submodule code wasn't being checked out.
in investigating it turns out the
SOURCE_VERSIONvariable is not available in CI butHEROKU_TEST_RUN_BRANCHis so this PR checks ifCIis true and if so, usesHEROKU_TEST_RUN_BRANCHvariable for the checkout command else uses the existingSOURCE_VERSIONvariable.