Verify complete engagement date override ranges are valid

Author: CarsonF

src/components/engagement/engagement.service.ts

@@ -1,8 +1,11 @@
 import { forwardRef, Inject, Injectable } from '@nestjs/common';
 import {
+  CalendarDate,
   ID,
   InputException,
   ObjectView,
+  Range,
+  RangeException,
   SecuredList,
   Session,
   UnsecuredDto,
@@ -16,6 +19,7 @@ import {
   Logger,
   ResourceLoader,
 } from '~/core';
+import { AnyChangesOf } from '~/core/database/changes';
 import { Privileges } from '../authorization';
 import { CeremonyService } from '../ceremony';
 import { ProductService } from '../product';
@@ -67,6 +71,7 @@ export class EngagementService {
   ): Promise<LanguageEngagement> {
     await this.verifyCreateEngagement(input.projectId, session);
     this.verifyCreationStatus(input.status);
+    EngagementDateRangeException.throwIfInvalid(input);
 
     const engagement = await this.repo.createLanguageEngagement(
       input,
@@ -87,6 +92,7 @@ export class EngagementService {
   ): Promise<InternshipEngagement> {
     await this.verifyCreateEngagement(input.projectId, session);
     this.verifyCreationStatus(input.status);
+    EngagementDateRangeException.throwIfInvalid(input);
 
     const { id } = await this.repo.createInternshipEngagement(
       input,
@@ -172,6 +178,7 @@ export class EngagementService {
     this.privileges
       .for(session, LanguageEngagement, object)
       .verifyChanges(changes);
+    EngagementDateRangeException.throwIfInvalid(previous, changes);
 
     const updated = await this.repo.updateLanguage(
       {
@@ -218,6 +225,7 @@ export class EngagementService {
     this.privileges
       .for(session, InternshipEngagement, object)
       .verifyChanges(changes, { pathPrefix: 'engagement' });
+    EngagementDateRangeException.throwIfInvalid(previous, changes);
 
     const updated = await this.repo.updateInternship(
       { id: object.id, ...changes },
@@ -310,3 +318,33 @@ export class EngagementService {
     return ids.length > 0;
   }
 }
+
+class EngagementDateRangeException extends RangeException {
+  static throwIfInvalid(
+    current: Partial<
+      Pick<UnsecuredDto<Engagement>, 'startDateOverride' | 'endDateOverride'>
+    >,
+    changes: AnyChangesOf<Engagement> = {},
+  ) {
+    const start =
+      changes.startDateOverride !== undefined
+        ? changes.startDateOverride
+        : current.startDateOverride;
+    const end =
+      changes.endDateOverride !== undefined
+        ? changes.endDateOverride
+        : current.endDateOverride;
+    if (start && end && start > end) {
+      const field =
+        changes.endDateOverride !== undefined
+          ? 'engagement.endDateOverride'
+          : 'engagement.startDateOverride';
+      throw new EngagementDateRangeException({ start, end }, field);
+    }
+  }
+
+  constructor(readonly value: Range<CalendarDate>, readonly field: string) {
+    const message = "Engagement's start date must be before the end date";
+    super({ message, field });
+  }
+}