Verify project date ranges are valid

Author: CarsonF

src/common/exceptions/index.ts

@@ -1,5 +1,6 @@
 export * from './exception';
 export * from './input.exception';
+export * from './range.exception';
 export * from './duplicate.exception';
 export * from './not-found.exception';
 export * from './not-implemented.exception';

src/common/exceptions/range.exception.ts

@@ -0,0 +1,7 @@
+import { InputException } from '~/common';
+
+export class RangeException extends InputException {
+  constructor(options?: { message?: string; field?: string; cause?: Error }) {
+    super(options?.message ?? `Invalid range`, options?.field, options?.cause);
+  }
+}

src/components/project/project.service.ts

@@ -1,6 +1,7 @@
 import { forwardRef, Inject, Injectable } from '@nestjs/common';
 import { Many } from '@seedcompany/common';
 import {
+  CalendarDate,
   ClientException,
   CreationFailed,
   EnhancedResource,
@@ -10,6 +11,8 @@ import {
   many,
   NotFoundException,
   ObjectView,
+  Range,
+  RangeException,
   ReadAfterCreationFailed,
   Role,
   SecuredList,
@@ -27,6 +30,7 @@ import {
   Logger,
 } from '~/core';
 import { Transactional } from '~/core/database';
+import { AnyChangesOf } from '~/core/database/changes';
 import { Privileges } from '../authorization';
 import { withoutScope } from '../authorization/dto';
 import { BudgetService } from '../budget';
@@ -101,6 +105,7 @@ export class ProjectService {
     input: CreateProject,
     session: Session,
   ): Promise<UnsecuredDto<Project>> {
+    ProjectDateRangeException.throwIfInvalid(input);
     if (input.type !== ProjectType.Internship && input.sensitivity) {
       throw new InputException(
         'Can only set sensitivity on Internship Projects',
@@ -290,6 +295,8 @@ export class ProjectService {
       return await this.readOneUnsecured(input.id, session, changeset);
     }
 
+    ProjectDateRangeException.throwIfInvalid(currentProject, changes);
+
     let updated = currentProject;
     if (changedStep) {
       await this.workflow.executeTransitionLegacy(
@@ -611,3 +618,23 @@ export class ProjectService {
     );
   }
 }
+
+class ProjectDateRangeException extends RangeException {
+  static throwIfInvalid(
+    current: Partial<Pick<UnsecuredDto<Project>, 'mouStart' | 'mouEnd'>>,
+    changes: AnyChangesOf<Project> = {},
+  ) {
+    const start =
+      changes.mouStart !== undefined ? changes.mouStart : current.mouStart;
+    const end = changes.mouEnd !== undefined ? changes.mouEnd : current.mouEnd;
+    if (start && end && start > end) {
+      const field = changes.mouEnd ? 'project.mouEnd' : 'project.mouStart';
+      throw new ProjectDateRangeException({ start, end }, field);
+    }
+  }
+
+  constructor(readonly value: Range<CalendarDate>, readonly field: string) {
+    const message = "Project's MOU start date must be before the MOU end date";
+    super({ message, field });
+  }
+}