Ignore no-unnecessary-condition where I'm confident the condition is warranted

Author: CarsonF

src/components/changeset/changeset.arg.ts

@@ -38,10 +38,11 @@ export const ChangesetArg = (
       ValidateChangesetEditablePipe,
     )(target, methodName, argIndex);
 
-    // method metadata is set after parameter metadata, so wait until next tick
-    // to determine if method is query or mutation to set default description.
+    // method metadata is set after parameter metadata, so wait until the next tick
+    // to determine if method is query or mutation to set the default description.
     process.nextTick(() => {
       type = Reflect.getMetadata(TypeKey, (target as any)[methodName!]);
+      // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition -- double-checking at runtime
       if (!type) {
         throw new ServerException(
           'Something went wrong trying to determine operation type',

src/components/file/file.service.ts

@@ -134,6 +134,8 @@ export class FileService {
       }
       throw new ServerException('Failed to retrieve file contents', e);
     }
+    // I think this is a safety check for our S3 mocks
+    // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
     if (!data) {
       throw new NotFoundException('Could not find file contents');
     }

src/components/file/media/detect-existing-media.migration.ts

@@ -81,7 +81,7 @@ export class DetectExistingMediaMigration extends BaseMigration {
       }
       yield* currentPage;
       page++;
-      // eslint-disable-next-line no-constant-condition
+      // eslint-disable-next-line no-constant-condition,@typescript-eslint/no-unnecessary-condition
     } while (true);
   }
 

src/components/file/media/media-detector.service.ts

@@ -36,8 +36,11 @@ export class MediaDetector {
       return {
         __typename: 'Image',
         dimensions: {
+          // Guarding against library lies
+          /* eslint-disable @typescript-eslint/no-unnecessary-condition */
           width: size.width ?? 0,
           height: size.height ?? 0,
+          /* eslint-enable  @typescript-eslint/no-unnecessary-condition */
         },
       };
     }

src/components/location/location.gel.repository.ts

@@ -57,12 +57,15 @@ export class LocationGelRepository
     const locations = e.select(node)[
       rel as keyof typeof node
     ] as typeof e.Location;
+    // Types may be misleading, confirm at runtime.
+    /* eslint-disable @typescript-eslint/no-unnecessary-condition */
     if (!locations) {
       throw new ServerException(`${label} does not have a "${rel}" link`);
     }
     if (locations.__element__.__name__ !== 'default::Location') {
       throw new ServerException(`${label}.${rel} is not a link to Locations`);
     }
+    /* eslint-enable  @typescript-eslint/no-unnecessary-condition */
     const all = e.select(locations, (obj) => ({
       ...this.applyFilter(obj, input),
       ...this.applyOrderBy(obj, input),

src/components/periodic-report/handlers/sync-progress-report-to-engagement.handler.ts

@@ -101,6 +101,8 @@ export class SyncProgressReportToEngagementDateRange
               engagementRange(event.previous),
             ];
       Settings.throwOnInvalid = true;
+      // I turned off throw on invalid above for this, so it is necessary despite the type inconsistency
+      // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
       if (prev && !prev.isValid) {
         this.logger.error('Found invalid date range for event', {
           eventType: event.constructor.name,
@@ -109,6 +111,7 @@ export class SyncProgressReportToEngagementDateRange
         });
         throw new Error('Invalid engagement date range');
       }
+      // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
       if (updated && !updated.isValid) {
         this.logger.error('Found invalid date range for event', {
           eventType: event.constructor.name,

src/components/product/product.service.ts

@@ -81,8 +81,12 @@ export class ProductService {
     }
 
     const otherInput: CreateOtherProduct | undefined =
+      // Double-checking not undefined seems safer here since a union type
+      // could have this field declared as undefined.
+      // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
       'title' in input && input.title !== undefined ? input : undefined;
     const derivativeInput: CreateDerivativeScriptureProduct | undefined =
+      // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
       'produces' in input && input.produces !== undefined ? input : undefined;
     const scriptureInput: CreateDirectScriptureProduct | undefined =
       !otherInput && !derivativeInput ? input : undefined;

src/components/progress-report/migrations/reextract-all-progress-reports.migration.ts

@@ -93,6 +93,6 @@ async function* createPaginator<T>(
     }
     yield* currentPage;
     page++;
-    // eslint-disable-next-line no-constant-condition
+    // eslint-disable-next-line no-constant-condition,@typescript-eslint/no-unnecessary-condition
   } while (true);
 }

src/components/progress-summary/progress-summary.extractor.ts

@@ -58,7 +58,7 @@ const findFiscalYearRow = (sheet: ProgressSheet, fiscalYear: number) => {
 
 const findLatestCumulative = (currentYear: Row<ProgressSheet>) => {
   const { sheet } = currentYear;
-  // eslint-disable-next-line no-constant-condition
+  // eslint-disable-next-line no-constant-condition,@typescript-eslint/no-unnecessary-condition
   while (true) {
     const summary = summaryFrom(currentYear, ...sheet.columnsForCumulative);
     if (summary.planned > 0 || summary.actual > 0) {

src/core/database/errors.ts

@@ -112,6 +112,7 @@ export const createBetterError = (e: Error) => {
   if (!isNeo4jError(e)) {
     return e;
   }
+  // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
   e.message ??= ''; // I've seen the message be null
 
   const better = cast(e);