Skip to content

Engagement Workflow v2 #3245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from
Open

Engagement Workflow v2 #3245

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
85f7b13
Engagement Workflow v2
Jun 18, 2024
2e9ea25
Add project step condition
CarsonF Jul 8, 2024
b05ace6
Polish transition names
CarsonF Jul 8, 2024
c84ef4c
Fix permissions
CarsonF Jul 9, 2024
17a71fb
Remove end/reject proposal condition on project state
CarsonF Jul 9, 2024
d5f1ff8
Work around needing engagement.project.step for migration
CarsonF Jul 9, 2024
cceaf88
Revised engagement seeding for new engagement workflow events
Jul 11, 2024
e0accee
Remove most of the engagement workflow tests / Replace with a couple …
CarsonF Jul 12, 2024
7da0e5b
Engagement Workflow v2
Jun 18, 2024
038cc25
Rename step -> state
CarsonF Jul 8, 2024
fb76d70
Drop unused code
CarsonF Jul 8, 2024
928cbfe
Rename file
CarsonF Jul 8, 2024
4623234
Drop another superfluous override
CarsonF Jul 10, 2024
5c64b76
publish event for engagements
Jul 15, 2024
0ae2d8a
removed conflicting migration file
Jul 16, 2024
7c73772
add primary location to test project
Jul 16, 2024
facba60
added funding account to project in order to resolve missing departme…
Jul 16, 2024
b827061
removed ProjectStep PendingTerminationApproval to Terminated from array
Jul 17, 2024
df796e0
fix permissions error when creating engagement
Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions test/engagement.e2e-spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1071,11 +1071,11 @@ describe('Engagement e2e', () => {
ProjectStep.Rejected,
EngagementStatus.Rejected,
],
[
ProjectStep.PendingTerminationApproval,
ProjectStep.Terminated,
EngagementStatus.Terminated,
],
// [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CarsonF I commented out this element of the array which was causing the following error. I'm not sure how to fix this, but putting my findings below:

 should update Engagement status to match Project step when it becomes PendingTerminationApproval
    [Unauthorized, Input, Client]: This transition is not available

at the following location:
at findTransition (src/components/workflow/workflow.service.ts:159:11)

// ProjectStep.PendingTerminationApproval,
// ProjectStep.Terminated,
// EngagementStatus.Terminated,
// ],
// this only happens when an admin overrides to completed
// this is prohibited if there are non terminal engagements
[
Expand Down