Add Language.usesAIAssistance boolean #3538
Open
+67
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🗞 GraphQL SummaryView schema changes@@ -2508,8 +2508,16 @@
"""The earliest start date from its engagements."""
sponsorStartDate: SecuredDate!
tags: SecuredTags!
+
+ """
+ Whether any engagement for this language is using AI-assisted translation.
+
+ This is true if any engagement's "usingAIAssistedTranslation" property is not "None" or "Unknown".
+ Used to track and filter languages that have AI assistance in their translation process.
+ """
+ usesAIAssistance: SecuredBoolean!
}
type LanguageEngagement implements ChangesetAware & Commentable & Engagement & Resource {
"""Whether the requesting user can delete this resource"""
@@ -2625,8 +2633,11 @@
registryOfLanguageVarietiesCode: String
"""Only these sensitivities"""
sensitivity: [Sensitivity!]
+
+ """Only languages that have an AI-assisted translation engagement"""
+ usesAIAssistance: Boolean
}
input LanguageListInput {
"""The number of items to return in a single page"""
|
rdonigian
force-pushed
the
ai-assistance-lang-field
branch
2 times, most recently
from
803a478 to
3eafd80
Compare
📝 WalkthroughWalkthroughA new calculated field, Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~15 minutes Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (4)
🧰 Additional context used🧠 Learnings (3)📓 Common learnings📚 Learning: in the seedcompany/cord-api-v3 project, edgedb/gel migrations are stored in `/dbschema/migrations/` ...Applied to files:
📚 Learning: files in the migrations folder (e.g., dbschema/migrations/*.edgeql) are generated and not meant to b...Applied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
🔇 Additional comments (2)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
src/components/language/dto/language.dto.ts(1 hunks)src/components/language/dto/list-language.dto.ts(1 hunks)src/components/language/language.gel.repository.ts(1 hunks)src/components/language/language.repository.ts(5 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: CarsonF
PR: SeedCompany/cord-api-v3#3438
File: src/components/language/migrations/add-flags.migration.ts:6-8
Timestamp: 2025-07-08T14:12:59.042Z
Learning: In the SeedCompany/cord-api-v3 project PR #3438, the isWiderComm field was initially planned to be added to the Language entity but was subsequently removed during development. Only the isAvailableForReporting field remained in the final implementation.
📚 Learning: in the seedcompany/cord-api-v3 project pr #3438, the iswidercomm field was initially planned to be a...
Learnt from: CarsonF
PR: SeedCompany/cord-api-v3#3438
File: src/components/language/migrations/add-flags.migration.ts:6-8
Timestamp: 2025-07-08T14:12:59.042Z
Learning: In the SeedCompany/cord-api-v3 project PR #3438, the isWiderComm field was initially planned to be added to the Language entity but was subsequently removed during development. Only the isAvailableForReporting field remained in the final implementation.
Applied to files:
src/components/language/language.gel.repository.tssrc/components/language/dto/list-language.dto.tssrc/components/language/dto/language.dto.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: E2E Tests (neo4j 1/6)
- GitHub Check: E2E Tests (neo4j 3/6)
- GitHub Check: E2E Tests (neo4j 6/6)
- GitHub Check: E2E Tests (neo4j 4/6)
- GitHub Check: E2E Tests (neo4j 5/6)
- GitHub Check: E2E Tests (neo4j 2/6)
- GitHub Check: Unit
- GitHub Check: Clean
- GitHub Check: lint
- GitHub Check: Generate (base)
- GitHub Check: Generate (head)
🔇 Additional comments (5)
src/components/language/dto/language.dto.ts (1)
187-196: LGTM!The new calculated field is well-implemented with proper decorators, clear documentation, and appropriate typing. The description accurately reflects the business logic for determining AI assistance usage.
src/components/language/language.repository.ts (4)
383-400: Query logic looks correct for detecting AI assistance usage.The
usingAIAssistancefragment correctly:
- Matches language engagements through the proper relationship path
- Checks the
usingAIAssistedTranslationproperty values- Excludes null, "None", and "Unknown" values as specified in the DTO description
- Uses
any()function to return true if any engagement meets the criteria
212-212: Integration with hydrate method is properly implemented.The fragment is correctly applied in the hydration pipeline and the result is properly included in the returned DTO fields.
Also applies to: 226-226
344-347: Filter implementation follows established patterns.The filter correctly applies the
usingAIAssistancefragment and uses the computed value for filtering. The implementation is consistent with other boolean filters in the codebase.
433-437: Sorter implementation is consistent and correct.The sorter properly applies the
usingAIAssistancefragment and uses the computed value for sorting, following the same pattern as other computed field sorters.
rdonigian
force-pushed
the
ai-assistance-lang-field
branch
from
3eafd80 to
4411d7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
usesAIAssistanceboolean toLanguagewhich computesusingAIAssistedTranslationfrom relatedEngagements