Random tweaks on recent changes

[CarsonF]

No description provided.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR relocates AsyncLocalStorageNoContextException from src/core/ to src/common/exceptions/ and moves SecuredTags from language-specific to common GraphQL objects. Multiple resolvers are updated to accept and prime data loaders. Import paths and decorator configurations are adjusted accordingly.

Changes

Cohort / File(s)	Summary
Exception Relocation src/common/exceptions/async-local-storage-no-context.exception.ts, src/common/exceptions/index.ts, src/core/async-local-storage-no-context.exception.ts, src/core/index.ts	Moves AsyncLocalStorageNoContextException from core to common/exceptions module with updated export index and removal from core.
Secured GraphQL Types src/common/graphql/objects/concretes/secured-scalars.ts, src/components/language/dto/language.dto.ts, src/components/project/dto/project.dto.ts	Relocates SecuredTags class from language DTO to common secured-scalars, updating imports in dependent files.
Engagement Resolver Loaders src/components/engagement/engagement.resolver.ts	Adds EngagementLoader parameter to four mutations (createLanguageEngagement, createInternshipEngagement, updateLanguageEngagement, updateInternshipEngagement) with loader priming using changeset view.
Product Resolver Loaders src/components/product/product.resolver.ts	Injects ProductLoader parameter into six mutations (create/update variants) with cache priming via loader.prime(). Updates import source for LoaderOf.
Core Import Updates src/core/authentication/session/session.host.ts, src/core/graphql/gql-context.host.ts	Updates import statements to reference relocated AsyncLocalStorageNoContextException from ~/common.
Project Member & DTO Updates src/components/project/project-member/project-member.resolver.ts, src/components/project/dto/project-mutations.dto.ts	Refactors updateProjectMember payload destructuring with defaults; simplifies ProjectMutationOrDeletion @InterfaceType decorator by removing custom resolveType function.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• Fix EngagmentMutation.engagement specialization #3638: Modifies engagement resolver mutation methods (updateLanguageEngagement, updateInternshipEngagement) with related payload handling and return shape changes.
• Apollo -> Yoga Server #3303: Refactors exception exports and imports involving AsyncLocalStorageNoContextException relocation from core to common.
• Project Mutation Subscriptions (CDC) #3613: Updates ProjectMutationOrDeletion DTO decorator in the same file, removing resolveType configuration.

🚥 Pre-merge checks | ✅ 2 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided, but the template requires a description section explaining the changes and a Monday task link or reason for the PR.	Add a description explaining the changes (moving exceptions to common, adding loader priming to resolvers, consolidating imports) and include a Monday task link or reason for the PR.
Title check	❓ Inconclusive	The title 'Random tweaks on recent changes' is vague and does not convey meaningful information about the specific changes made.	Provide a more descriptive title that summarizes the main objective, such as 'Move AsyncLocalStorageNoContextException to common module' or 'Add loader priming to mutation resolvers'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into develop

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch cleanup

---

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments

src/components/product/product.resolver.ts (1)

17-17: Minor import path inconsistency with other resolvers.

This file now imports Loader/LoaderOf from ~/core/data-loader, while engagement.resolver.ts (line 17) imports the same symbols from ~/core. Both work if ~/core re-exports from ~/core/data-loader, but the inconsistency is worth noting.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}