Only get client_id when GUI presents option#15
Open
AStoker wants to merge 1 commit intoSeeed-Solution:mainfrom
Open
Only get client_id when GUI presents option#15AStoker wants to merge 1 commit intoSeeed-Solution:mainfrom
AStoker wants to merge 1 commit intoSeeed-Solution:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting up the ESP32 Sense from the "Discovered" integration, it doesn't ask for the client id. However, the code is trying to access that entered client id, resulting in an error like this
Instead, move the
client_idsetting down into thehas_mqtt_topicwhich is when we know we'll actually need the client id.