Skip to content

Disable text selection on ShortPassCard#406

Draft
JSchmerling wants to merge 6 commits intoSeineEloquenz:mainfrom
JSchmerling:No-select
Draft

Disable text selection on ShortPassCard#406
JSchmerling wants to merge 6 commits intoSeineEloquenz:mainfrom
JSchmerling:No-select

Conversation

@JSchmerling
Copy link
Contributor

No description provided.

@JSchmerling JSchmerling marked this pull request as draft December 18, 2025 19:01
@JSchmerling JSchmerling marked this pull request as ready for review December 18, 2025 19:17
@JSchmerling
Copy link
Contributor Author

I'm not sure if it's better in terms of performance to set DisableSelect directly in PassView.

@SeineEloquenz
Copy link
Owner

This does not work for me. As I understand the docs, DisableSelection only works inside a SelectionContainer, not when wrapping it.

@JSchmerling JSchmerling marked this pull request as draft December 21, 2025 20:30
@JSchmerling JSchmerling changed the title Disable text selection on ShortPassCard WIP: Disable text selection on ShortPassCard Dec 21, 2025
@JSchmerling
Copy link
Contributor Author

I have analyzed the whole thing and would like to ask how I should proceed before correcting the PR.
There are two possible solutions. First, set DisableSelection for the PassLabels. However, this would affect both PassCards. Second, treat both cards individually. However, this would involve more overhead.
I would still recommend this feature, as it improves the UX after a long click.

@JSchmerling JSchmerling marked this pull request as ready for review January 8, 2026 12:10
@JSchmerling JSchmerling changed the title WIP: Disable text selection on ShortPassCard Disable text selection on ShortPassCard Jan 8, 2026
@SeineEloquenz
Copy link
Owner

SeineEloquenz commented Jan 24, 2026

I don't know what the better solution is. The selection annoys me for quite some time because of the upstream bug that makes it hard to deselect the text again.
Maybe we should just migrate from the selection to some other concept completely, but I have no good idea.

@JSchmerling JSchmerling marked this pull request as draft February 14, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants