Hide feature + Pin feature №5#513
Draft
JSchmerling wants to merge 13 commits intoSeineEloquenz:mainfrom
Draft
Conversation
* №4 * №4 (new files) * fixing * Fix sorting by using correct comparator reference * Remove hide and pin functions from WalletViewModel Removed hide, unhide, pin, and unpin functions from WalletViewModel. * Implement hide, unhide, pin, and unpin functions Add functions to hide, unhide, pin, and unpin passes in PassViewModel. * Add state management for visibility and pinning Added MutableStateFlow properties for isHidden and isPinned. * Add authentication and visibility state management * Update authentication handling in WalletScreen * Add asStateFlow import to PassViewModel * Fix isAuthenticated state source in WalletView * Fix typo in walletViewModel reference * Remove unused isHidden and isPinned state flows Removed unused state flows for isHidden and isPinned. * Refactor condition checks for pinned and hidden states * Refactor PassScreen to remove unused parameters Removed unused parameters isPinned and isHidden from Actions and PassScreen. * Refactor PassViewModel to remove hidden and pinned states Removed isHidden and isPinned state management from PassViewModel. * Refactor hide, unhide, pin, and unpin methods Simplified hide, unhide, pin, and unpin functions by removing unnecessary context switching. * Refactor biometric authentication code style * Remove isHidden and isPinned functions Removed isHidden and isPinned functions from PassStore. * Remove isHidden and isPinned functions Removed isHidden and isPinned functions from PassRepository. * Remove unused isHidden and isPinned methods Removed isHidden and isPinned functions from PassDao. * Fix syntax error in unpin function declaration * Update PassScreen.kt
Contributor
Author
|
Since some major changes are currently being made, I am keeping this PR in draft mode and will adapt it accordingly once the changes have been implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up and fix of #478
Hopefully, this is the last iteration. Since the last iteration, two main changes have been made: