feat: check/execute EL payload on certify#167
Open
matthias-wright wants to merge 4 commits intodevelopfrom
Open
feat: check/execute EL payload on certify#167matthias-wright wants to merge 4 commits intodevelopfrom
matthias-wright wants to merge 4 commits intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the EL payload is not verified by Simplex. This is an optimization to avoid EL payload execution on the consensus hot path. Instead, the EL payload of notarized/finalized blocks is verified when the blocks are executed by the finalizer actor.
If a block contains an invalid EL payload, Reth will reject and skip it. The block stays in Summit's chain in case it was a finalized block. Summit keeps track of Reth's forkchoice.
The consequence of this is that Summit's height might be larger than Reth's height.
This PR explores an alternative approach, where the EL payload is verified in
CertifiableAutomaton::certify. This will prevent finalizations of blocks with invalid EL payload.Benchmarks show that this will reduce the blocks per second by around 5.9%.
Changes:
check_payloadinCertifiableAutomaton::certify