Skip to content

uvloop fixes #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lc525 merged 7 commits into from
Dec 15, 2025
Merged

uvloop fixes #2297

lc525 merged 7 commits into from
Dec 15, 2025

Conversation

@lc525
Copy link
Member

@lc525 lc525 commented Dec 3, 2025 •
edited
Loading

PR fixing MLServer custom image builds (and future MLServer images) for uvloop >= 0.22.1.

This also positions MLServer to be resilient to all the async API changes coming into future python versions (3.14 - 3.16), mostly caused by the deprecation of the async loop policy APIs.

Notes for reviewer

  • Most important changes in mlserver/utils.py and mlserver/parallel/worker.py. Everything else is related to necessary adjustments to testing
  • CI tests for the alibi-detect, alibi-explain and huggingface runtimes fail due to lack of disk space. I've run the tests locally and most unit tests pass, but there are a small number of failures.
  • CI tests for mlserver fail with 3 errors related to building custom environments and running models using those environments on top of the MLServer code from the current PR -- however, those failures only happen because the custom environments are built based on MLServer from master. Once this PR is merged, those tests should pass (and do so locally)

@lc525 lc525 marked this pull request as draft December 3, 2025 03:40
lc525 added 2 commits December 14, 2025 22:20
@lc525
Add manager to handle the async engine
be6447c 
- Updates required for uvloop >= 0.22.1, following deprecations in the python API
regarding async loop policies.

- Updates to pytest to run tests using async correctly

- Updates to runtimes so that pytest doesn't load the same module (conftest.py)
multiple times. This involves adding __init__.py files in intermediate
directories to explicitly define python packages.
@lc525
Update poetry lock files
f5e024b
@lc525 lc525 marked this pull request as ready for review December 15, 2025 01:34
domsolutions
domsolutions approved these changes Dec 15, 2025
View reviewed changes
Copy link

@domsolutions domsolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MiguelAAe
MiguelAAe approved these changes Dec 15, 2025
View reviewed changes
Copy link

@MiguelAAe MiguelAAe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lc525 lc525 merged commit 5f28474 into SeldonIO:master Dec 15, 2025
35 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domsolutions domsolutions domsolutions approved these changes

+1 more reviewer

@MiguelAAe MiguelAAe MiguelAAe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lc525 @MiguelAAe @domsolutions