-
Notifications
You must be signed in to change notification settings - Fork 855
feat(all): Add release version to binaries #6912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60c0416 to
3c09783
Compare
lc525
approved these changes
Dec 9, 2025
Member
lc525
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, some minor suggestions and comments
Co-authored-by: Lucian Carata <[email protected]>
Co-authored-by: Lucian Carata <[email protected]>
Co-authored-by: Lucian Carata <[email protected]>
fa17cef to
b86ab9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When customers have issues dpeloying new releases, from looking at their logs, it's hard to tell if we're looking at the previous version or newly deployed version. This PR injects the release tag at compile time for binaries:
It will print the version to the logs when the pod spins up. Additionally added
-versionas an arg, which will print the version and exit.Summary of changes
scheduler/v2.10.0operator/v2.10.0which all point to the same commit, it won't make any sense to have the operator to print versionscheduler/v2.10.0for example. Instead we just set the tag provided by the releaser with${{ github.event.inputs.docker-tag }}. We should look at if we really need all these different tags and can simplify it.Checklist
Testing