Skip to content

Conversation

@domsolutions
Copy link
Contributor

Motivation

Intention is tests within a feature directory will contain their own server_setup.feature which will setup the required servers for the test. The server setup can either be run individually with:

go test  --godog.paths ./features/model/server_setup.feature 

Or can run all features in the directory with enough concurrency configured to run all tests including the server setup. In this case, the tests will need to be written with generous enough timeouts to wait for godog to run the server scenario and deploy the server/s so other tests can complete

go test --godog.concurrency 10  --godog.paths ./features/model

Summary of changes

Checklist

  • Added/updated unit tests
  • Added/updated documentation
  • Checked for typos in variable names, comments, etc.
  • Added licences for new files

Testing

@MiguelAAe
Copy link
Contributor

A few thoughts after reviewing the pr;

with the current way this inference server is set up it will be spin up and deleted after running isn't it? I can see that we append the world tags so after running the scenario it will be deleted. https://github.com/SeldonIO/seldon-core/pull/7012/changes#diff-a6d47dad0d18baa746a5d0174b07baf9ebfc7154bb92ed0a8b7a344ab09ba8c1R127

@domsolutions domsolutions merged commit 6b822f7 into v2 Dec 15, 2025
5 checks passed
@domsolutions domsolutions deleted the godog/server-setup branch December 15, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants