Merged
Conversation
| scheduler := NewSimpleScheduler(logger, mockModelServerAPI, DefaultSchedulerConfig(mockModelServerAPI), synchroniser.NewSimpleSynchroniser(time.Duration(10*time.Millisecond)), eventHub) | ||
| err := scheduler.Schedule(test.modelName) | ||
| //model, err := scheduler.store.GetModel(test.modelName) //todo? | ||
| //model.GetLastAvailableModel().Replicas //todo? |
Contributor
There was a problem hiding this comment.
I think it's fine to not do this as it's not an integration test and the model wouldn't actually be updated right as we're just using mocks?
MiguelAAe
force-pushed
the
mig/exp-ha-scheduler
branch
from
6f624bc to
ff24b3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Issues
Motivation
What
Summary of changes
Checklist
Testing