-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
SE_NODE_RELAY_STEREOTYPE_EXTRA to append custom capabilities to default Relay stereotype #2625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
e738f50
to
d080417
Compare
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
9efcd47
to
908352a
Compare
…lt Relay stereotype Signed-off-by: Viet Nguyen Duc <[email protected]>
908352a
to
cc9a9f5
Compare
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
To use environment variables for generate relay configs, set
SE_NODE_RELAY_URL
and other variables as below. Those will be used to generate the default relay config in TOML format looks like below.Instead of input value for each environment variable to construct the default relay stereotype, you can use the
SE_NODE_RELAY_STEREOTYPE
environment variable to overwrite the default relay stereotype with your custom stereotype.In another case, if you want to retain the default relay stereotype and append additional capabilities, you can use the
SE_NODE_RELAY_STEREOTYPE_EXTRA
environment variable to set your capabilities. Those will be merged to the default relay stereotype.Motivation and Context
Types of changes
Checklist
PR Type
Enhancement, Documentation, Tests
Description
Introduced
SE_NODE_RELAY_STEREOTYPE
andSE_NODE_RELAY_STEREOTYPE_EXTRA
environment variables for enhanced relay configuration.Updated relay configuration logic to support merging custom capabilities into default relay stereotypes.
Enhanced documentation to explain new environment variables and their usage.
Added test configurations to validate the new relay stereotype functionality.
Changes walkthrough 📝
3 files
Documented new relay stereotype environment variables.
Updated relay configuration examples and added details for new
variables.
Added descriptions for new relay stereotype variables.
2 files
Improved shell script formatting logic with error handling.
Added logic to merge custom relay stereotypes using
SE_NODE_RELAY_STEREOTYPE_EXTRA
.2 files
Removed deprecated `SE_NODE_MAX_CONCURRENCY` configuration.
Added default values for new relay stereotype variables.
2 files
Added test configuration for `SE_NODE_RELAY_STEREOTYPE_EXTRA`.
Updated relay configuration to reflect new stereotype logic.