-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
K8s: Bump new KEDA image for feature preview #2681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Viet Nguyen Duc <[email protected]>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
CI Feedback 🧐(Feedback updated until commit 2af207a)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
Signed-off-by: Viet Nguyen Duc <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
986983a to
2af207a
Compare
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement, Tests, Documentation
Description
Added support for
enableManagedDownloadsin Selenium Grid scaler.enableManagedDownloadsfor scaler configuration.Enhanced test coverage for
enableManagedDownloadsfunctionality.Updated documentation for Selenium Grid scaler.
enableManagedDownloads.Minor configuration and dependency updates.
KEDA_BASED_TAGin Makefile and fixed a condition in Helm chart dependencies.Changes walkthrough 📝
selenium_grid_scaler.go
Support managed downloads in Selenium Grid scaler.keda/scalers/selenium_grid_scaler.go
enableManagedDownloadsfield to scaler metadata.enableManagedDownloads.getCountFromSeleniumResponseto includeenableManagedDownloads.selenium_grid_scaler_test.go
Add tests for managed downloads in scaler.keda/scalers/selenium_grid_scaler_test.go
enableManagedDownloads.enableManagedDownloadsparameter.README.md
Update README with new PR references.keda/README.md
selenium-grid-scaler.md
Document managed downloads in Selenium Grid scaler.keda/scalers/selenium-grid-scaler.md
enableManagedDownloadsmetadata field.Makefile
Update KEDA_BASED_TAG in MakefileMakefile
KEDA_BASED_TAGto a new version.Chart.yaml
Fix Helm chart dependency conditioncharts/selenium-grid/Chart.yaml
kube-prometheus-stackdependency.