-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Docker: Resolve default component port via env var #2689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
CI Feedback 🧐(Feedback updated until commit 5c63630)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
b110e85 to
5c63630
Compare
Signed-off-by: Viet Nguyen Duc <[email protected]>
5c63630 to
54b47f3
Compare
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement, Documentation
Description
Updated environment variables for default ports across components.
Replaced
SE_SESSIONS_HOSTandSE_SESSIONS_PORTwithSE_SESSIONS_MAP_HOSTandSE_SESSIONS_MAP_PORT.Added default port values for several components in Dockerfiles and documentation.
Simplified
docker-composefiles by removing redundant environment variables.Changes walkthrough 📝
1 files
Replace `SE_SESSIONS_HOST` and `SE_SESSIONS_PORT` with new variables15 files
Add default port environment variables for DistributorAdd default port environment variables for EventBusAdd default port environment variable for HubAdd default port environment variables for RouterAdd default port environment variable for SessionQueueAdd default port environment variables for SessionsUpdate environment variables for session map deploymentSimplify environment variables for development compose fileSimplify environment variables for external datastore compose fileSimplify environment variables for nightly compose fileSimplify environment variables for secure compose fileSimplify environment variables for tracing compose fileSimplify environment variables for default compose fileRemove deprecated session environment variablesAdd default values for new environment variables1 files
Document default port values for environment variables