-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
K8s: Update overProvisionRatio to use scalingModifiers instead scaler trigger param #2930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
db81aa9
to
019074a
Compare
… trigger param Signed-off-by: Viet Nguyen Duc <[email protected]>
109f56b
to
70b2926
Compare
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Config
autoscaling.scaledOverProvisionRatio
- The number of overprovisioning ratio to scale more than the actual number of requests. For example, over over-provisioning ratio1.2
means 20% more than the actual requests.Applicable for Deployment autoscaling only.
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
Refactor autoscaling configuration to use KEDA scalingModifiers
Replace overProvisionRatio with scaledOverProvisionRatio parameter
Update Helm templates for improved scaling logic
Add new default trigger configuration options
Diagram Walkthrough
File Walkthrough
4 files
Add job scaling type template test
Update test values for new scaling parameter
Update test configuration with new parameters
Update solution template with new parameters
2 files
Refactor autoscaling template with scalingModifiers
Replace overProvisionRatio with scaledOverProvisionRatio
1 files
Disable patched KEDA testing
1 files
Update documentation for new scaling parameters
4 files
Fix template formatting consistency
Fix template formatting consistency
Fix template formatting consistency
Fix template formatting consistency