Skip to content

Conversation

f-lopes
Copy link
Contributor

@f-lopes f-lopes commented Sep 19, 2025

User description

Description

Fix minor typo in Helm helper function (monitoring): ingress -> monitoring

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Bug fix


Description

  • Fix typo in Helm template comment for monitoring helper function

File Walkthrough

Relevant files
Documentation
_helpers.tpl
Fix comment typo in monitoring helper                                       

charts/selenium-grid/templates/_helpers.tpl

  • Corrected comment from "Is ingress enabled" to "Is monitoring enabled"
    for the monitoring helper function
+1/-1     

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Possible Mismatch

The change updates only a comment string to "Is monitoring enabled". Verify that no other references or docs rely on the previous comment wording and that helper naming and values keys remain consistent across the chart.

Is monitoring enabled
*/}}
{{- define "seleniumGrid.monitoring.enabled" -}}
{{- or .Values.monitoring.enabled .Values.monitoring.enabledWithExistingAgent | ternary "true" "" -}}
{{- end -}}

Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@VietND96 VietND96 merged commit 0c77268 into SeleniumHQ:trunk Sep 20, 2025
24 of 28 checks passed
@VietND96
Copy link
Member

Thank you, @f-lopes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants