-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Docker: Remove pre-gen self-sign cert in image #2962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
Signed-off-by: Viet Nguyen Duc <[email protected]>
911ae10
to
a1927ab
Compare
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
For security best practices. Dummy self-sign cert won't be generated and attached to image by default anymore.
Refer to https://github.com/SeleniumHQ/docker-selenium?tab=readme-ov-file#secure-connection
Now, users have to prepare these artifacts: Truststore file .jks, truststore password, server certificate file .crt, server private key (in PKCS8 format) and volume mount to container
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
Remove pre-generated self-signed certificates from Docker image
Comment out certificate copying and trust operations
Update Makefile to skip certificate generation step
Add new NodeAllBrowsers Dockerfile for multi-browser support
Diagram Walkthrough
File Walkthrough
Dockerfile
Disable certificate operations in base image
Base/Dockerfile
CERT_TRUST_ATTR
argument definitionMakefile
Update build process and error handling
Makefile
gen_certs
dependency frombase
target|| true
for Chrome and Edge buildsall_browsers
targetDockerfile
Add new all-browsers node Dockerfile
NodeAllBrowsers/Dockerfile