Skip to content

Conversation

VietND96
Copy link
Member

@VietND96 VietND96 commented Sep 27, 2025

User description

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Other


Description

  • Update Docker versions in CI workflows

  • Bump rclone version to v1.71.1

  • Add Firefox 143 browser support

  • Update Chrome and Edge versions


Diagram Walkthrough

flowchart LR
  A["Dependencies"] --> B["Docker versions"]
  A --> C["rclone v1.71.1"]
  A --> D["Browser versions"]
  D --> E["Firefox 143"]
  D --> F["Chrome/Edge updates"]
Loading

File Walkthrough

Relevant files
Dependencies
Dockerfile
Bump rclone version                                                                           

.ffmpeg/Dockerfile

  • Update rclone version from v1.71.0 to v1.71.1
+1/-1     
helm-chart-test.yml
Update Docker versions in Helm tests                                         

.github/workflows/helm-chart-test.yml

  • Update Docker versions across multiple test configurations
  • Upgrade from 28.3.3 to 28.4.0, 26.1.4 to 27.5.1, and 27.4.1 to 27.5.1
+5/-5     
k8s-scaling-test.yml
Update Docker versions in K8s tests                                           

.github/workflows/k8s-scaling-test.yml

  • Update Docker versions in Kubernetes scaling test matrix
  • Upgrade from 28.3.3 to 28.4.0, 27.4.1 to 27.5.1, and 26.1.4 to 27.5.1
+3/-3     
Enhancement
release-firefox-versions.yml
Add Firefox 142 support                                                                   

.github/workflows/release-firefox-versions.yml

  • Add Firefox version 142 to the browser versions list
  • Extend supported Firefox versions array
+1/-1     
browser-matrix.yml
Add Firefox 143 and update browser versions                           

tests/build-backward-compatible/browser-matrix.yml

  • Add Firefox 143.0.1 with multi-platform support
  • Update Chrome stable to 140.0.7339.207-1
  • Update Edge stable to 140.0.3485.94-1
+5/-2     
firefox-matrix.yml
Add Firefox 143 to matrix                                                               

tests/build-backward-compatible/firefox-matrix.yml

  • Add Firefox version 143.0.1 to the matrix
+2/-0     

Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Version Coverage

Firefox 143 is added to test matrices but not included in the workflow default browser versions list; confirm if it should be appended to the default array to keep release and tests aligned.

browser-versions:
  description: 'List browser version to build. E.g: [130, 131]'
  required: true
  default: '[98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142]'
Consistency

New Firefox 143 entry is added here and in firefox-matrix but the release workflow’s default still tops at 142; validate downstream jobs won’t skip 143 images.

'143':
  FIREFOX_VERSION: 143.0.1
  FIREFOX_PLATFORMS: linux/amd64,linux/arm64
'142':

Copy link
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Align release workflow with test matrices

Add Firefox version 143 to the default browser-versions list in the
release-firefox-versions.yml workflow to align with the updated test matrices.

.github/workflows/release-firefox-versions.yml [34]

-default: '[98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142]'
+default: '[98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143]'
  • Apply / Chat
Suggestion importance[1-10]: 6

__

Why: The suggestion correctly identifies an inconsistency where Firefox version 143 was added to test matrices but missed in the release workflow's default versions, thus improving configuration consistency.

Low
  • More

@VietND96 VietND96 merged commit 84440a4 into trunk Sep 27, 2025
55 of 59 checks passed
@VietND96 VietND96 deleted the chore-deps branch September 27, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant